Add support for content in config #1952
Conversation
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jvitor83 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
There was a problem hiding this comment.
This code looks amazing! Could you please update the documentation matrix as well for compatibility?
I believe we need to add another entry there. https://github.com/kubernetes/kompose/blob/main/docs/conversion.md
Otherwise, awesome code / changes and AMAZING tests. Big thanks!
|
Done as asked! |
| @@ -231,6 +232,97 @@ func TestCreateServiceWithServiceUser(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestCreateServiceWithConfigLongSyntax(t *testing.T) { | |||
There was a problem hiding this comment.
@cdrage are the e2e tests still running?
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closes #1947
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added support to
contentinconfigelement.Unit test included.
Which issue(s) this PR fixes:
Fixes #1947