fixup! Create additional NEGs based on subnets in Node Topology CR.

sawsa307 · sawsa307 · commit 6d44fe7249dc · 2024-11-07T03:49:55.000Z
diff --git a/pkg/neg/syncers/transaction.go b/pkg/neg/syncers/transaction.go
@@ -469,7 +469,7 @@ func (s *transactionSyncer) ensureNetworkEndpointGroups() error {
 			negName = s.namer.NonDefaultSubnetNEG(s.NegSyncerKey.Namespace, s.NegSyncerKey.Name, subnetConfig.Name, s.NegSyncerKey.PortTuple.Port)
 			if s.customName {
 				if len(s.NegSyncerKey.NegName) > negtypes.MaxDefaultSubnetNegNameLength {
-					s.logger.Error(err, "Unable to create custom NEGs in non-default subnet", "customNegName", s.NegSyncerKey.Name)
+					s.logger.Error(ErrCustomNEGNameTooLong, "Unable to create custom NEGs in non-default subnet", "customNegName", s.NegSyncerKey.Name)
 					errList = append(errList, ErrCustomNEGNameTooLong)
 					continue
 				}

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ func (s *transactionSyncer) ensureNetworkEndpointGroups() error {`
`469`	`469`	`negName = s.namer.NonDefaultSubnetNEG(s.NegSyncerKey.Namespace, s.NegSyncerKey.Name, subnetConfig.Name, s.NegSyncerKey.PortTuple.Port)`
`470`	`470`	`if s.customName {`
`471`	`471`	`if len(s.NegSyncerKey.NegName) > negtypes.MaxDefaultSubnetNegNameLength {`
`472`		`- s.logger.Error(err, "Unable to create custom NEGs in non-default subnet", "customNegName", s.NegSyncerKey.Name)`
	`472`	`+ s.logger.Error(ErrCustomNEGNameTooLong, "Unable to create custom NEGs in non-default subnet", "customNegName", s.NegSyncerKey.Name)`
`473`	`473`	`errList = append(errList, ErrCustomNEGNameTooLong)`
`474`	`474`	`continue`
`475`	`475`	`}`