Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timeout field for Lifecycle PreStop Hook ExecAction and PostStart Hook ExecAction #4929

Open
4 tasks
googs1025 opened this issue Oct 23, 2024 · 5 comments
Open
4 tasks
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@googs1025
Copy link

googs1025 commented Oct 23, 2024

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add Timeout field for Lifecycle PreStop Hook ExecAction and PostStart Hook ExecAction
  • Kubernetes Enhancement Proposal: TODO:
  • Discussion Link: Enhancement for ExecAction in Pod Lifecycle kubernetes#128250
  • Primary contact (assignee): @googs1025
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.33
    • Beta release target (x.y): 1.34
    • Stable release target (x.y): 1.35
  • Alpha
    • KEP (k/enhancements) update PR(s): TODO
    • Code (k/k) update PR(s): TODO
    • Docs (k/website) update PR(s): TODO

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 23, 2024
@googs1025
Copy link
Author

googs1025 commented Oct 23, 2024

I think this feature is needed and needs a KEP tracked. Can you give me some feedback? If the feedback is positive, I will try to provide a KEP.
cc @SergeyKanzhelev @thockin @mrunalp @haircommander @kannon92

@googs1025
Copy link
Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 23, 2024
@googs1025
Copy link
Author

/assign

@googs1025 googs1025 changed the title Add Timeout field for Lifecycle PreStop Hook and PostStart Hook Add Timeout field for Lifecycle PreStop Hook ExecAction and PostStart Hook ExecAction Oct 23, 2024
@toVersus
Copy link

This is an issue for tracking the status of the KEP, so it might be better to have detailed discussions in the issue linked under "Discussion Link" (kubernetes/kubernetes#128250). We're still at the early stage before submitting the initial KEP.

https://github.com/kubernetes/enhancements?tab=readme-ov-file#when-to-comment-on-an-enhancement-issue
Please do not comment on the enhancement issue to:

  • discuss a detail of the design, code or docs. Use a linked-to-issue or PR for that

@googs1025
Copy link
Author

@toVersus ! Thanks for the guidance, I will remove these comments and comment in the appropriate place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

3 participants