[Tracking] VPA Helm Chart Implementation

[omerap12]

Following our discussions in the last two SIG meetings, we’ve decided to create a dedicated Helm chart for the VPA 🥳

This issue will serve as a tracking hub for contributors. We’ll use it to collect and organize the tasks needed for this effort. Additional items may be added over time as the work progresses.

At the moment, we’re aiming to achieve the following:

Admission Controller:

• nodeSelector / affinity / tolerations
• Helm hooks for TLS cert patching / rotation
• PodDisruptionBudget - feat(chart): add PodDisruptionBudget chart for admission controller #8651

Recommender:

• Deployment - feat(vpa-chart): add chart logic for the vpa recommender #8646
• ServiceAccount - feat(vpa-chart): add chart logic for the vpa recommender #8646
• RBAC (ClusterRole, RoleBinding) - feat(vpa-chart): add chart logic for the vpa recommender #8646
• ConfigMap (optional tuning parameters) - feat(vpa-chart): add chart logic for the vpa recommender #8646
• PodDisruptionBudget - feat(vpa-chart): add chart logic for the vpa recommender #8646
• nodeSelector / affinity / tolerations - feat(vpa-chart): add chart logic for the vpa recommender #8646

Updater:

• Deployment
• ServiceAccount
• RBAC (ClusterRole, RoleBinding)
• PodDisruptionBudget
• Resource requests/limits
• nodeSelector / affinity / tolerations

CRDs:

• Package CRDs in a dedicated CRDs chart - Add crds chart for the VPA #8661

Other:

• ServiceMonitor / PodMonitor (Prometheus Operator support)
• Add optional imagePullSecrets
• Add configurable commands
• Add schema validation for values.yaml (values.schema.json)
• Support PodSecurity admission labels (restricted/baseline)
• Optionally integrate with cert-manager for webhook TLS (instead of Helm hook patching)
• SecurityContext (drop capabilities, runAsNonRoot, readOnlyRootFilesystem)
• PriorityClass support

[maxcao13]

Thanks for creating this @omerap12!

Are we going to take a donated existing VPA helm chart, or is this from scratch? I thought there was some discussion around that.

[omerap12]

Thanks for creating this @omerap12!

Are we going to take a donated existing VPA helm chart, or is this from scratch? I thought there was some discussion around that.

If someone wants to donate, we are fine with that as long as it comes in via a PR that we all review.
As if it was code written from scratch :)

[iamzili]

@omerap12 thanks for creating this issue. Just asking ... how do people get involved in working on parts of the helm chart? For example if someone chooses to create the helm chart for Recommender, should this be announced in this ticket?

[omerap12]

@omerap12 thanks for creating this issue. Just asking ... how do people get involved in working on parts of the helm chart? For example if someone chooses to create the helm chart for Recommender, should this be announced in this ticket?

Probably just mention you are gonna work on that ( so other folks won't work on the same thing ) and then submit a PR :)

[omerap12]

/area vertical-pod-autoscaler
/good-first-issue
/triage accepted

[k8s-ci-robot]

@omerap12:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/area vertical-pod-autoscaler
/good-first-issue
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[itstrueitstrueitsrealitsreal]

/assign

[maxcao13]

I can do the recommender tasks.