Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7435 Support New Alibaba Cloud ENV Variables names for RRSA Authorization #7436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

7435 Support New Alibaba Cloud ENV Variables names for RRSA Authorization #7436

wants to merge 1 commit into from
+69 −17

Conversation

maximrub
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the newly declared official environment variable names by Alibaba Cloud for RRSA to authorize pods to access different cloud services. This change enables compatibility with both the existing and new ENV variable names, ensuring seamless authorization for pods accessing various Alibaba Cloud services.
This update is essential for users transitioning to the updated naming conventions while maintaining support for legacy configurations.

Which issue(s) this PR fixes:

Fixes #7435

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no

NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maximrub
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/alicloud Issues or PRs related to the AliCloud cloud provider implementation labels Oct 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @maximrub. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2024
@Shubham82
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2024
@Shubham82
Copy link
Contributor

cc @ringtail

@ringtail
Copy link
Contributor

ringtail commented Nov 1, 2024

cc @IrisIris Pls take a look.

@maximrub
Copy link
Contributor Author

maximrub commented Nov 6, 2024

Hi @ringtail, can someone have a look?

@ringtail
Copy link
Contributor

ringtail commented Nov 7, 2024

Hi @ringtail, can someone have a look?

I‘ll ping @IrisIris again.

@IrisIris
Copy link
Contributor

IrisIris commented Nov 7, 2024

@maximrub LGTM. It would be even better if you could add a unit test for this new function 'FirstNotEmpty'.

@maximrub
Copy link
Contributor Author

maximrub commented Nov 7, 2024 •
edited
Loading

@maximrub LGTM. It would be even better if you could add a unit test for this new function 'FirstNotEmpty'.

@IrisIris added a UT
bfc0563

@maximrub
Copy link
Contributor Author

maximrub commented Nov 7, 2024

@Shubham82 can you help with this pr also? thank you

@Shubham82
Copy link
Contributor

It seems good to me, I will LGTM once it is confirmed by the owner CC @ringtail @IrisIris.

@IrisIris
Copy link
Contributor

LGTM

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024
@Shubham82
Copy link
Contributor

cc @x13n
Please approve this PR, so that it will merge (as it was reviewed by Alicoud owners)

Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2024
@maximrub maximrub requested a review from x13n November 15, 2024 10:23
@x13n
Copy link
Member

x13n commented Nov 15, 2024

Thanks! Can you also squash the commits?

@maximrub
7435 Support New Alibaba Cloud ENV Variables names for RRSA Authoriza…
dcd6d6a 
…tion in Cluster Autoscaler

Signed-off-by: Maxim Rubchinsky <[email protected]>
@maximrub maximrub force-pushed the fr-7435-alibaba-cloud-rrsa-new-env-vars branch from d3bfcfe to dcd6d6a Compare November 16, 2024 10:04
@maximrub
Copy link
Contributor Author

Thanks! Can you also squash the commits?

@x13n done

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2024
@Shubham82
Copy link
Contributor

/retitle 7435 Support New Alibaba Cloud ENV Variables names for RRSA Authorization

@k8s-ci-robot k8s-ci-robot changed the title 7435 Support New Alibaba Cloud ENV Variables names for RRSA Authoriza… 7435 Support New Alibaba Cloud ENV Variables names for RRSA Authorization Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@vadasambar vadasambar Awaiting requested review from vadasambar

@x13n x13n Awaiting requested review from x13n

Assignees

@Shubham82 Shubham82

Labels
area/cluster-autoscaler area/provider/alicloud Issues or PRs related to the AliCloud cloud provider implementation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support New Alibaba Cloud ENV Variables names for RRSA Authorization in Cluster Autoscaler
6 participants
@maximrub @k8s-ci-robot @Shubham82 @ringtail @IrisIris @x13n