Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP: InstanceTemplates are no longer global resources #7396

Open
4wdonny opened this issue Oct 15, 2024 · 9 comments
Open

GCP: InstanceTemplates are no longer global resources #7396

4wdonny opened this issue Oct 15, 2024 · 9 comments
Labels
area/cluster-autoscaler area/provider/gce kind/bug Categorizes issue or PR as related to a bug.

Comments

@4wdonny
Copy link

4wdonny commented Oct 15, 2024

Which component are you using?:
Cluster Autoscaler

cluster-autoscaler
What version of the component are you using?: 1.29.4

Component version: 1.29.4

What k8s version are you using (kubectl version)?:

v1.29.8-gke.1096000

kubectl version Output
$ kubectl version

What environment is this in?: Google

GCP has changed the location of instance templates...they used to be Global and now they are regional. Is this configurable in the Autoscaler?

@4wdonny 4wdonny added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2024
@4wdonny
Copy link
Author

4wdonny commented Oct 15, 2024

Last night a node pool was upgraded to 1.29.8-gke.1096000 and the underlying instance template for the MIG changed from a global one to a regional one.

@4wdonny 4wdonny closed this as completed Oct 15, 2024
@4wdonny 4wdonny reopened this Oct 15, 2024
@4wdonny
Copy link
Author

4wdonny commented Oct 15, 2024

I've tried master, and even creating a new node spot node pool, and it looks like this is broken. The instanceTemplate regional logic is not being called correctly.

@Shubham82
Copy link
Contributor

/area provider/gce
/area cluster-autoscaler

@Shubham82
Copy link
Contributor

cc @BigDarkClown @x13n

@aaktaev
Copy link

aaktaev commented Oct 16, 2024

Same for k8s=1.29.9-gke.1177000 and ClusterAutoscaler appVersion=v1.29.3:

Unable to build proper template node for https://www.googleapis.com/compute/v1/projects/$PROJECT/zones/europe-west1-b/instanceGroups/gke-k8s-system-grp: googleapi: Error 404: The resource 'projects/$PROJECT/global/instanceTemplates/gke-k8s-system-7777777' was not found, notFound

@x13n
Copy link
Member

x13n commented Oct 16, 2024

This has been fixed in CA 1.29 (#7231), but not 1.28. I just created1.28 cherrypick here: #7409

@4wdonny
Copy link
Author

4wdonny commented Oct 17, 2024

@x13n I attempted using CA 1.29 and encountered the same issue.

@x13n
Copy link
Member

x13n commented Oct 18, 2024 via email

@Shubham82
Copy link
Contributor

Hi @4wdonny, the patch release for CA (1.28-1.31) is out. Could you please check if all things work fine?
if the issue is resolved so can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/gce kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants