-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divisor
resource.Quantity
omitempty
doesn't make sense
#75
Comments
Divisor
resource.Quantity
omitempty
doesn't make sense
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/assign |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/assign |
tried pushing my commit i got permission denied |
please open a PR in https://github.com/kubernetes/kubernetes/ this repo is auto-generated from the code in that original repository |
https://github.com/kubernetes/api/blob/master/core/v1/types.go#L2309
When you
json.Marshal()
aResourceFieldSelector
with undefinedDivisor
, you getdivisor: "0"
This is bad for 2 reasons:
omitempty
is meaningless hereDivisor
should default to1
. Since it actually defaults to0
, you get unintended behavior and incorrect resultsDivisor
instead should be a pointer*resource.Quantity
instead of justresource.Quantity
The text was updated successfully, but these errors were encountered: