Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.1 release tag is moved to a newer commit #2367

Closed
dzjiang91 opened this issue May 4, 2023 · 4 comments
Closed

2.7.1 release tag is moved to a newer commit #2367

dzjiang91 opened this issue May 4, 2023 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dzjiang91
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
Recently 2.7.1 tag is now moved to a newer commit (#2325) while the tag was originally created with an older one (#2229 or #2239).

What you expected to happen:
We should not move the release tag after it is pushed. Instead of moving an existing tag, it would be better practice to make a new release like 2.7.1.1 or 2.7.2. Such practice should be avoided in the future releases.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
We usually assume that the binary / image is fixed after an upstream release (say 2.7.1 or 3.0). It would be very confusing that there are new changes merged after that and different binaries or images might get built / pulled with the same release tag.

Environment:

  • csi-vsphere version: 2.7.1
  • vsphere-cloud-controller-manager version:
  • Kubernetes version:
  • vSphere version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 4, 2023
@mauriciopoppe
Copy link
Member

Somewhat related: a dev tried to retag a repo in registry.k8s.io . It didn’t go through though because tags are immutable there kubernetes/k8s.io#5221

@adikul30
Copy link
Contributor

adikul30 commented May 8, 2023

@nikhilbarge can you help take a look at this issue

@nikhilbarge
Copy link
Contributor

Tag 2.7.1 was recreated that is why there is change in commit sha.
we have taken note of this issue, In future we will take care such practice is not followed , and not move the release tag once pushed.

@divyenpatel
Copy link
Member

@dzjiang91

Thank you for bringing this to our attention. We will ensure that the tag is never overridden in this repository again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

6 participants