You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What happened:
Recently 2.7.1 tag is now moved to a newer commit (#2325) while the tag was originally created with an older one (#2229 or #2239).
What you expected to happen:
We should not move the release tag after it is pushed. Instead of moving an existing tag, it would be better practice to make a new release like 2.7.1.1 or 2.7.2. Such practice should be avoided in the future releases.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
We usually assume that the binary / image is fixed after an upstream release (say 2.7.1 or 3.0). It would be very confusing that there are new changes merged after that and different binaries or images might get built / pulled with the same release tag.
Environment:
csi-vsphere version: 2.7.1
vsphere-cloud-controller-manager version:
Kubernetes version:
vSphere version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:
The text was updated successfully, but these errors were encountered:
Tag 2.7.1 was recreated that is why there is change in commit sha.
we have taken note of this issue, In future we will take care such practice is not followed , and not move the release tag once pushed.
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
Recently 2.7.1 tag is now moved to a newer commit (#2325) while the tag was originally created with an older one (#2229 or #2239).
What you expected to happen:
We should not move the release tag after it is pushed. Instead of moving an existing tag, it would be better practice to make a new release like 2.7.1.1 or 2.7.2. Such practice should be avoided in the future releases.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
We usually assume that the binary / image is fixed after an upstream release (say 2.7.1 or 3.0). It would be very confusing that there are new changes merged after that and different binaries or images might get built / pulled with the same release tag.
Environment:
uname -a
):The text was updated successfully, but these errors were encountered: