Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR (spyglass/lenses) allow configuration sandbox permissions #296 broke spyglass #369

Open
oliver-goetz opened this issue Feb 3, 2025 · 1 comment
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release.

Comments

@oliver-goetz
Copy link
Contributor

In deck image us-docker.pkg.dev/k8s-infra-prow/images/deck:v20250202-8cd7d6837 spyglass is broken.
It shows the following error message when opening it.

error rendering spyglass page: error rendering template: template: spyglass.html:46:106: executing "content" at <$config.IframeSandboxPermissions>: can't evaluate field IframeSandboxPermissions in type lenses.LensConfig

PR #296 looks like the most likely reason for it.

I don't know exactly how the config is parsed. When checking the error message it looks like LensConfig needs to be extended with IframeSandboxPermissions that it can be used in spyglass.html.
LensConfig is part of the structure used for rendering the template and it includes the fields Name and HideTitle which are used in the same line of the template.

@oliver-goetz
Copy link
Contributor Author

/kind regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release.
Projects
None yet
Development

No branches or pull requests

2 participants