Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose job envrionments in prow.yaml #3 #185

Open
ileixe opened this issue Jun 8, 2024 · 2 comments
Open

Expose job envrionments in prow.yaml #3 #185

ileixe opened this issue Jun 8, 2024 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ileixe
Copy link
Contributor

ileixe commented Jun 8, 2024

Hi, congratulations on the independence of repo.

I'd like to ask feature request about our main painpoint to use prow: Environment variables are not available when prow job is defined.

Let me give specific example,

presubmits:
  - name: lint
    agent: tekton-pipeline
    tekton_pipeline_run_spec:
      v1beta1:
        pipelineRef:
          resolver: git
          params:
          # You need to change this revision when you update lint.yaml
          - name: revision
            value: a6ea90d4a7122bf1f43519ddfc86678cc35de30f # Here's what we need to specify PULL_PULL_SHA
          - name: pathInRepo
            value: tekton/lint.yaml
          - name: repo
            value: your-repo

As you can see, we need to bump up the revision whenever the referring yaml is updated even the repo itself is the same one that prow.yaml triggered. If we can use environment variables here, we can just depend on latest (and which is correct) yaml in PR.

Now, we're committing twice whenever the config itself is updated, and it's not only very annoying but also non-intuitive where newcomers always make mistake.

It's from tekton-pipeline agent, but underlying problem exists in the same way where user requires PULL_PULL_SHA when they define prow.yaml.

Can we expose such variables when converting prow.yaml to ProwJob?

Thanks.

@BenTheElder
Copy link
Member

Kubernetes does not use tekton pipelines currently, I don't know how much bandwidth there is for working on this controller.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants