Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prow config: where possible, all config should behave like branchprotector for overrides #221

Open
matthyx opened this issue Aug 7, 2024 · 1 comment · May be fixed by #147
Open

prow config: where possible, all config should behave like branchprotector for overrides #221

matthyx opened this issue Aug 7, 2024 · 1 comment · May be fixed by #147
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@matthyx
Copy link
Contributor

matthyx commented Aug 7, 2024

initial issue: kubernetes/test-infra#9757

The branchprotector override mechanism is amazing and we should use it in every config where people can configure orgs or repos, etc, to allow for more specific overrides. More specifically, plugins like approve have a flat list of configs and don't have any override logic, but users expect it and commit configuration that does nothing.
@matthyx matthyx linked a pull request Aug 7, 2024 that will close this issue
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement ConfigTree in approve plugin matthyx/prow
3 participants
@k8s-ci-robot @matthyx @k8s-triage-robot