Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation page on using Kueue to run Notebook #3878

Open
1 task
mimowo opened this issue Dec 18, 2024 · 3 comments
Open
1 task

Documentation page on using Kueue to run Notebook #3878

mimowo opened this issue Dec 18, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Dec 18, 2024

What would you like to be added:

A documentation page under https://kueue.sigs.k8s.io/docs/tasks/run/ showing how to use Kueue to run Kubeflow Notebook.

Then we should also update the main README and reference the page from the "Features overview / Integrations" point.

This is a follow up to #3352

Why is this needed:

To showcase Kueue is supporting the running of Notebook. To guide users how to do it.

Completion requirements:

This enhancement requires the following artifacts:

  • Docs update

The artifacts should be linked in subsequent comments.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 18, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Dec 18, 2024

@varshaprasad96
Copy link
Member

Since the "kueue. x-k8s. io/ queue-name" label is not being added by the notebook-controller to STS, the notebook integration is not working out of the box.

Just tested it out, and looks like a small update in NB controller is needed.

I'll create a PR with NB controller to add NB CR labels to SS, and once it is done can create a doc PR in here.

@mimowo
Copy link
Contributor Author

mimowo commented Jan 30, 2025

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants