Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding karpenter.sh/nodeclaim-name:<nodeclaim-name> as label to a node #1668

Open
balraj-aqfer opened this issue Sep 16, 2024 · 4 comments
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@balraj-aqfer
Copy link

balraj-aqfer commented Sep 16, 2024

Description

What problem are you trying to solve?

This label is required to identify which bin-pack value of the resource request triggered the creation of an instance.

How important is this feature to you?
It is needed to identify the pod binpack overhead in our kubernetes clusters

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@balraj-aqfer balraj-aqfer added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 16, 2024
@njtran
Copy link
Contributor

njtran commented Sep 17, 2024

We previously attempted to do this here: #996 but it got put on the backburner in favor of other PRs. Let us know if you're interested in implementing!

@njtran njtran removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 17, 2024
@balraj-aqfer
Copy link
Author

I appreciate the update and understand that other priorities may have taken precedence.

I am indeed interested in contributing to Karpenter and would like to explore this further. However, I would appreciate some guidance on the internal source and architecture to better understand how I can effectively contribute to this effort. If there are any resources or documentation you could share, I would be grateful.

@njtran
Copy link
Contributor

njtran commented Sep 25, 2024

@Balraj06 I think the best guidance would be the previous PR I linked. You should be aware that this might be a deceptively harder thing to implement, since adding this as a label allows it to be potentially scheduled on with pods. We'd likely want to remove this from an allowable scheduling constraint in our simulations. Feel free to reach out in karpenter-dev for further advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants