Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports automatic deletion of instances when the limits of the NodePool is reduced #1604

Open
daimaxiaxie opened this issue Aug 28, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@daimaxiaxie
Copy link
Contributor

Description

What problem are you trying to solve?

When I descrease the NodePool limits, the excess resources cannot be automatically deleted.

Case:

  1. NodePool.limits.cpu = 512, It has 10 instances of 32C64G. cpu: 320
  2. Set NodePool.limits.cpu = 256, I hope karpenter can automatically delete 2 instances.

How important is this feature to you?

This feature is useful when upgrading infrastructure.

Upgrading the image case:
NodePool A, NodeClass A, Image A.
NodePool B, NodeClass B, Image B.
Administrator controls the upgrade progress: descrease NodePool A limits, increase NodePool B limits; Eventually B completely replaces A.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@daimaxiaxie daimaxiaxie added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants