Skip to content

Commit b198efd

Browse files
committed
Update TODOs
1 parent 4a2c02e commit b198efd

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

cmd/epp/runner/runner.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -521,13 +521,13 @@ func (r *Runner) parseConfigurationPhaseTwo(ctx context.Context, rawConfig *conf
521521
// Add requestControl plugins
522522
r.requestControlConfig.AddPlugins(handle.GetAllPlugins()...)
523523

524-
// TODO(rahulgurnani): Remove feature gate check once prepare data plugins are stable.
525-
if r.featureGates[datalayer.PrepareDataPluginsFeatureGate] {
526-
// Sort prepare data plugins in DAG order (topological sort). Also check prepare data plugins for cycles.
527-
if r.requestControlConfig.PrepareDataPluginGraph() != nil {
528-
return nil, errors.New("failed to load the configuration - prepare data plugins have cyclic dependencies")
529-
}
530-
} else {
524+
// Sort prepare data plugins in DAG order (topological sort). Also check prepare data plugins for cycles.
525+
if r.requestControlConfig.PrepareDataPluginGraph() != nil {
526+
return nil, errors.New("failed to load the configuration - prepare data plugins have cyclic dependencies")
527+
}
528+
// TODO(#1970): Remove feature gate check once prepare data plugins are stable.
529+
if !r.featureGates[datalayer.PrepareDataPluginsFeatureGate] {
530+
// If the feature gate is disabled, clear any prepare data plugins so they are not used.
531531
r.requestControlConfig.WithPrepareDataPlugins()
532532
}
533533

0 commit comments

Comments
 (0)