Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when upsert or create ignores a command #4815

Open
davhdavh opened this issue Oct 17, 2024 · 0 comments · May be fixed by #4816
Open

Log when upsert or create ignores a command #4815

davhdavh opened this issue Oct 17, 2024 · 0 comments · May be fixed by #4816
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@davhdavh
Copy link
Contributor

What would you like to be added:

The way the Policy class is implemented, it will silently drop the entire range of endpoints to update without any notification on what or
why it does this.

e.g. here the list of Deletes are just dropped:

return &Changes{
Create: changes.Create,
UpdateOld: changes.UpdateOld,
UpdateNew: changes.UpdateNew,
}

Please add a log that reports which entries are ignored in

return &Changes{
and
return &Changes{

Why is this needed:

external-dns is too much of a blackbox that just does its own thing and hard to tell why.

@davhdavh davhdavh added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 17, 2024
@davhdavh davhdavh linked a pull request Oct 17, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant