Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal IPv6 addresses are used when ExternalAddress is specified. #4807

Open
TroyKomodo opened this issue Oct 15, 2024 · 2 comments · May be fixed by #4808
Open

Internal IPv6 addresses are used when ExternalAddress is specified. #4807

TroyKomodo opened this issue Oct 15, 2024 · 2 comments · May be fixed by #4808
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@TroyKomodo
Copy link

TroyKomodo commented Oct 15, 2024 •
edited
Loading

683663e#diff-14de035cd51595a543622295768037ac376d511bc269c0f41f36cd6737db01bdR84

(

external-dns/source/service.go

Line 314 in 683663e

if address.Type == v1.NodeExternalIP || (address.Type == v1.NodeInternalIP && suitableType(address.Address) == endpoint.RecordTypeAAAA) {
)

This commit introduced a change which checks if the ipv6 address is internal and uses it regardless of if we only want external ips. This seems very wrong.

I patched this out on my build and use a custom image.
@TroyKomodo TroyKomodo added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2024
@TroyKomodo
Copy link
Author

image image

@TroyKomodo
Copy link
Author 

apiVersion: v1
kind: Service
metadata:
  name: headless
  namespace: app
  labels:
    app: cdn
  annotations:
    external-dns.alpha.kubernetes.io/endpoints-type: NodeExternalIP
    external-dns.alpha.kubernetes.io/hostname: "..."
    external-dns.alpha.kubernetes.io/cloudflare-proxied: "false"
spec:
    ...

TroyKomodo added a commit to TroyKomodo/external-dns that referenced this issue Oct 15, 2024
@TroyKomodo
fix: internal ipv6 being used as external
75b913e 
Closes kubernetes-sigs#4807
@TroyKomodo TroyKomodo linked a pull request Oct 15, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: internal ipv6 being used as external TroyKomodo/external-dns
1 participant
@TroyKomodo