Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespace option in crictl ps #1494

Closed
linrl3 opened this issue Jul 15, 2024 · 2 comments · Fixed by #1632
Closed

Support namespace option in crictl ps #1494

linrl3 opened this issue Jul 15, 2024 · 2 comments · Fixed by #1632
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@linrl3
Copy link

linrl3 commented Jul 15, 2024

What would you like to be added:

Add a flag option in crictl ps command. In https://github.com/kubernetes-sigs/cri-tools/blob/master/cmd/crictl/util.go#L107 there is a podNamespaceRegexp option. But I didn't understand why we don't have it in flag option. I could create a PR if the it is needed.

Why is this needed:

After adding this, we can filter by namespace.

Tasks

No tasks being tracked yet.
@linrl3 linrl3 added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 15, 2024
@saschagrunert
Copy link
Member

@linrl3 thank you for the request! 🙏 I think the reason is that the pod usually carries the information about the namespace. Means we probably need an additional RPC on container list to check in which namespace the pod of the container resides. I'm not sure about that, but you're free to propose the change as a PR.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2024
@saschagrunert saschagrunert removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2024
@saschagrunert saschagrunert self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants