Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller-runtime/pkg/controller/name.go usedNames is global #2994

Open
qJkee opened this issue Oct 21, 2024 · 2 comments
Open

controller-runtime/pkg/controller/name.go usedNames is global #2994

qJkee opened this issue Oct 21, 2024 · 2 comments

Comments

@qJkee
Copy link

qJkee commented Oct 21, 2024

Hi. While developing a controllers, i did implement graceful shutdown for controllers and restart them afterwards. But, even the controller manager is being recreated, the usedNames map is not cleaned and there are no mechanism to do so.
I'm wondering if this can be improved and maybe tied to controller.Manager

@troy0820
Copy link
Member

This PR set the unique naming validation up where this PR added the option to skip the naming validation. It sounds like you can take advantage of this.

@qJkee
Copy link
Author

qJkee commented Nov 13, 2024

Yep, thanks for sharing. Not the best option to skip device validation for the whole operator but looks like that's the only option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants