In favor of what is EventBroadcaster manager option deprecated?

[valdar]

The EventBroadcaster manager option has been deprecated for a while:

controller-runtime/pkg/manager/manager.go

Lines 248 to 253 in 5615941

	// EventBroadcaster records Events emitted by the manager and sends them to the Kubernetes API
	// Use this to customize the event correlator and spam filter
	//
	// Deprecated: using this may cause goroutine leaks if the lifetime of your manager or controllers
	// is shorter than the lifetime of your process.
	EventBroadcaster record.EventBroadcaster

Are there suggested alternatives?

The deprecation comment seems more a warning of usage than anything else; might be that "Deprecated" is the wrong wording?

[valdar]

/kind support

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[valdar]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[valdar]

/remove-lifecycle rotten

[erikgb]

The field was deprecated in #1089, and by following breadcrumbs I found this interesting comment: DataDog/chaos-controller#684 (comment).

I am guessing the standard controller migration path is to use

controller-runtime/pkg/cluster/cluster.go

Line 62 in e3347b5

GetEventRecorderFor(name string) record.EventRecorder

instead. But I am trying to get this confirmed.

[alvaroaleman]

I am guessing the standard controller migration path is to use

GetEventRecorder uses the broadcaster underneath. It doesn't look like there is a replacement, fixing #2141 would probably help with that.