-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Go patch version bumps #11224
Comments
@sbueringer: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/triage accepted |
It's worth checking if dependabot can do this (but I think it can't) |
@sbueringer , would it be okay if I take a look at this unless someone has already started working? |
Sure! /assign @pravarag |
@sbueringer, I've started implementing as per the below suggestion:
I'll share the updates very soon. |
Opened a WIP PR here: #11237 as I still need to test the code, will update accordingly. |
@sbueringer , I'm looking for a way to test the changes. If I run the GH workflow normally, would that be enough or there is some different process I can use. Please let me know :) |
I would do the following on my CAPI fork:
|
Hi @sbueringer , apologies on delaying this change from my side. After making some smaller changes and testing, the PR is now ready for review. I've added more details related to the tests done here: #11237 (comment) Kindly let me know if there are any further changes to be made. |
I think it would be nice if we could automate Go patch version bumps on the main branch via a GitHub action.
Usually our Go patch version bump PR look like this: #11156
I would suggest to first get rid of the additional occurence of the Go version in the Tiltfile and then automate the bump for the Go version in the Makefile
The idea is roughly:
Example for an action that opens PRs: https://github.com/kubernetes-sigs/controller-tools/blob/main/.github/workflows/tools-releases.yml
/help
/area ci
/kind feature
The text was updated successfully, but these errors were encountered: