Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pint lint failure on CPUThrottlingHigh alert #985

Open
4 tasks done
skl opened this issue Nov 7, 2024 · 1 comment · May be fixed by #986
Open
4 tasks done

[Bug]: Pint lint failure on CPUThrottlingHigh alert #985

skl opened this issue Nov 7, 2024 · 1 comment · May be fixed by #986
Assignees
Labels
bug Something isn't working keepalive Use to prevent automatic closing

Comments

@skl
Copy link
Collaborator

skl commented Nov 7, 2024

What happened?

Pint lint failure, the docs on this check can be found here:

Please provide any helpful snippets.

prometheus_alerts.yaml:342-346 Warning: Aggregation using `without()` can be fragile when used inside binary expression because both sides must have identical sets of labels to produce any results, adding or removing labels to metrics used here can easily break the query, consider aggregating using `by()` to ensure consistent labels. (promql/fragile)
 342 |     "expr": |
 343 |       sum(increase(container_cpu_cfs_throttled_periods_total{container!="", job="cadvisor", }[5m])) without (id, metrics_path, name, image, endpoint, job, node)
 344 |         /
 345 |       sum(increase(container_cpu_cfs_periods_total{job="cadvisor", }[5m])) without (id, metrics_path, name, image, endpoint, job, node)
 346 |         > ( 25 / 100 )
make: *** [Makefile:80: pint-lint] Error 1

Originating PR:

What parts of the codebase are affected?

Alerts

I agree to the following terms:

  • I agree to follow this project's Code of Conduct.
  • I have filled out all the required information above to the best of my ability.
  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have confirmed this bug exists in the default branch of the repository, as of the latest commit at the time of submission.
@skl skl added the bug Something isn't working label Nov 7, 2024
@skl skl linked a pull request Nov 7, 2024 that will close this issue
@skl skl self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Dec 8, 2024

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keepalive Use to prevent automatic closing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant