Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong decorator mentioned in docs/components/pipelines/user-guides/components/containerized-python-components.md #3939

Open
ypitrey opened this issue Dec 4, 2024 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@ypitrey
Copy link

ypitrey commented Dec 4, 2024

I got to this page from the page on migrating from v1 to v2. There's a link there that reads "Change: Use the @dsl.container_component decorator as described in Container Components."

But this page does not mention the @dsl.container_component decorator, only the @dsl.component decorator. This is confusing 😅

@varodrig
Copy link
Contributor

@ypitrey would you like to contribute by submitting a PR with this change?

@varodrig
Copy link
Contributor

/help

Copy link

@varodrig:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added the help wanted Extra attention is needed label Jan 12, 2025
@siddarth2810
Copy link

is this the one ? the link to the below text is here but I dont see any link coming to this page

Image

@varodrig
Copy link
Contributor

is this the one ? the link to the below text is here but I dont see any link coming to this page

Image

yes, exactly it's mentioned to use the decorator but it's not reflected on the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants