Skip to content

Commit cc40702

Browse files
authored
Fix missing external types in apply configurations (#2429)
Signed-off-by: Antonin Stefanutti <[email protected]>
1 parent ab98a5a commit cc40702

File tree

9 files changed

+114
-64
lines changed

9 files changed

+114
-64
lines changed

hack/update-codegen.sh

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,30 @@ kube::codegen::gen_helpers \
3939
"${TRAINER_ROOT}/pkg/apis"
4040

4141
# Generate clients.
42+
externals=(
43+
"sigs.k8s.io/jobset/api/jobset/v1alpha2.JobSetSpec:sigs.k8s.io/jobset/client-go/applyconfiguration/jobset/v1alpha2"
44+
"k8s.io/api/core/v1.EnvVar:k8s.io/client-go/applyconfigurations/core/v1"
45+
"k8s.io/api/core/v1.EnvFromSource:k8s.io/client-go/applyconfigurations/core/v1"
46+
"k8s.io/api/core/v1.ResourceRequirements:k8s.io/client-go/applyconfigurations/core/v1"
47+
"k8s.io/api/core/v1.Toleration:k8s.io/client-go/applyconfigurations/core/v1"
48+
"k8s.io/api/core/v1.Volume:k8s.io/client-go/applyconfigurations/core/v1"
49+
"k8s.io/api/core/v1.VolumeMount:k8s.io/client-go/applyconfigurations/core/v1"
50+
"k8s.io/api/autoscaling/v2.MetricSpec:k8s.io/client-go/applyconfigurations/autoscaling/v2"
51+
)
52+
53+
apply_config_externals="${externals[0]}"
54+
for external in "${externals[@]:1}"; do
55+
apply_config_externals="${apply_config_externals},${external}"
56+
done
57+
4258
echo "Generating clients for Kubeflow Trainer"
4359
kube::codegen::gen_client \
4460
--boilerplate "${TRAINER_ROOT}/hack/boilerplate/boilerplate.go.txt" \
4561
--output-dir "${TRAINER_ROOT}/pkg/client" \
4662
--output-pkg "${TRAINER_PKG}/pkg/client" \
4763
--with-watch \
4864
--with-applyconfig \
65+
--applyconfig-externals "${apply_config_externals}" \
4966
"${TRAINER_ROOT}/pkg/apis"
5067

5168
# Get the kube-openapi binary to generate OpenAPI spec.

pkg/client/applyconfiguration/trainer/v1alpha1/containeroverride.go

Lines changed: 22 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/applyconfiguration/trainer/v1alpha1/datasetconfig.go

Lines changed: 11 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/applyconfiguration/trainer/v1alpha1/inputmodel.go

Lines changed: 11 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/applyconfiguration/trainer/v1alpha1/jobsettemplatespec.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/applyconfiguration/trainer/v1alpha1/outputmodel.go

Lines changed: 11 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/applyconfiguration/trainer/v1alpha1/podspecoverride.go

Lines changed: 13 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/applyconfiguration/trainer/v1alpha1/torchelasticpolicy.go

Lines changed: 10 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)