Hi @chahatsagarmain. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@mprahl can you review this ?

@mprahl can you review this ?

Thanks for the PR! Once the CI is passing I'll take a look, unless you have a specific question.

@mprahl The CI was passing on my forked repo but seems to fail here (Create kfp cluster specifically)

@mprahl The CI was passing on my forked repo but seems to fail here (Create kfp cluster specifically)

Could you please force push (e.g. amend the commit message and force push) to restart the CI? I don't have access to restart the jobs.

The logs in the failed CI shows:

2025-02-04 08:20:06,955 - INFO - ---- Pod kubeflow/ml-pipeline-persistenceagent-77596f6678-ln59f logs ----
persistence_agent flag redefined: kubeconfig
panic: persistence_agent flag redefined: kubeconfig

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0001f20e0, {0x2687438, 0x39d49d0}, {0x2310f9e, 0xa}, {0x237794b, 0x36})
	/usr/local/go/src/flag/flag.go:1028 +0x37d
flag.StringVar(...)
	/usr/local/go/src/flag/flag.go:885
main.init.0()
	/go/src/github.com/kubeflow/pipelines/backend/src/agent/persistence/main.go:153 +0x74

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rimolive for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

@chahatsagarmain , I think the issue is that the code change is now importing the Scheduled Workflow code, and both the Persistence Agent and Scheduled Workflow Go packages have init functions with some of the same flags.

Two options come to mind:

1. Rename those init functions so that they aren't called on import of the Go package, and explicitly call those functions in the main functions of each controller.
2. Move the common code of each controller to a separate package.