Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ScheduledWorkflow controller): Migrate the ScheduledWorkflow controller to use controller-runtime #11579

Open
mprahl opened this issue Jan 31, 2025 · 1 comment
Open

chore(ScheduledWorkflow controller): Migrate the ScheduledWorkflow controller to use controller-runtime #11579

mprahl opened this issue Jan 31, 2025 · 1 comment
Assignees
@chahatsagarmain

Comments

@mprahl
Copy link
Contributor

mprahl commented Jan 31, 2025 •
edited
Loading

Chore description

A lot of the code in the ScheduledWorkflow controller duplicates functionality in the controller-runtime library, which is a libary recommended by kubebuilder and operator-sdk.

The viewer controller in the Kubeflow Pipelines repo already uses controller-runtime, so we should aim to make this consistent.

This will reduce code duplication and make development easier in the future.

Labels

Love this idea? Give it a 👍.
@mprahl mprahl changed the title chore(ScheduledWorkflow controller): Migrate to using controller-runtime chore(ScheduledWorkflow controller): Migrate the ScheduledWorkflow controller to use controller-runtime Jan 31, 2025
@chahatsagarmain
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chahatsagarmain chahatsagarmain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mprahl @chahatsagarmain