Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node version 22 #63

Open
tariq-hasan opened this issue Nov 26, 2024 · 5 comments
Open

Upgrade to Node version 22 #63

tariq-hasan opened this issue Nov 26, 2024 · 5 comments

Comments

@tariq-hasan
Copy link

Since we definitely need this to reduce CVEs as well. We should even go to node 22 in follow up prs https://nodejs.org/en/about/previous-releases#release-schedule

Originally posted by @juliusvonkohout in kubeflow/kubeflow#7637 (comment)

@andreyvelich
Copy link
Member

Thank you for creating this, since we are in the process of migration code from kubeflow/kubeflow, let's use the kubeflow/dashboard repo to track this issue.

/transfer dashboard

@google-oss-prow google-oss-prow bot transferred this issue from kubeflow/kubeflow Nov 26, 2024
@thesuperzapper
Copy link
Member

thesuperzapper commented Nov 26, 2024

This will likely not be possible on the dashboard without a full rewrite, as we currently use Polymer, a framework which has been discontinued by Google a long time ago, so the latest Node version supported was 16.

There might be some people out there still maintaining a version of Polymer that supports Node 22, but if not, we will need to fully rewrite it.

We already started a rewrite in Angular (see: #38), but it's not feature complete yet, and has not been kept up to date with new features added to the Polymer version dashboard.

Also, now that we are using React for a lot of other UIs (Notebooks 2.0, Model Registry), we might want to consider that instead (but only if the people who are helping with those UIs want to help, and I doubt they will, as Red Hat does not use the dashboard because they have their own).

@tariq-hasan
Copy link
Author

Some points to note

  • We want to move away from using Polymer as a framework and build upon a clear migration plan to modernize the Kubeflow components.
  • There are more Angular-based components (Jupyter, TensorBoards, Volumes, Katib, KFServing) than there are React-based ones (Notebooks 2.0, Model Registry).

I think we want to double down on the existing effort to rewrite the dashboard in Angular and plan the Node.js version upgrade to 22 in the context of that rewrite.

If any implications carry over to Notebooks 2.0 and Model Registry UIs and how we mitigate them are another point of concern.

@thesuperzapper
Copy link
Member

@tariq-hasan is this something you would be willing and able to spearhead? (Brining the angular rewrite to feature parity with the polymer version)

I think the previous maintainer of the angular rewrite made a comment about the remaining tasks here:

@tariq-hasan
Copy link
Author

Thanks. I am moving over the discussion on the Angular rewrite to #38.

I am assuming that for now we park the Node.js version upgrade to 22 until the migration to the Angular version is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants