Skip to content

Correct two factual errors in the Terraform design spec #8

Description

@matt-edmondson

Context

The design spec at docs/superpowers/specs/2026-08-21-ktsu-dev-github-terraform-design.md contains two factual errors found during implementation. Both were stated confidently, so they are worth correcting rather than leaving for the next reader to trip over.

Error 1, the ruleset bypass actor

The spec says:

Integration 15368 is github-actions[bot]. This id is not a guess: ImGuiApp's existing ruleset already references integration_id: 15368 for its status checks.

That reasoning is wrong. integration_id inside required_status_checks names the app that reports a check. A bypass actor requires an app installed in the org. They are different requirements, and GitHub rejects the configuration:

HTTP 422: Actor GitHub Actions integration must be part of the ruleset source or owner organization

The spec should record that GitHub Actions cannot be a bypass actor in this org, and that the strict ruleset design is therefore not implementable as written.

Error 2, ProjectDirector's topics

The spec says ProjectDirector's live 20 topics "differ from first-20 by ordering". They did not. The 20-topic cap dropped dotnet and csharp, which sat last in its TAGS.md, and libgit2sharp was not in that file at all. Applying would have removed dotnet from a .NET repository.

The file has since been trimmed, removing project director (duplicated the repo name) and imgui (duplicated dear imgui), bringing it to exactly 20 normalized topics with dotnet and csharp retained. The spec text still describes the old, wrong reasoning.

Also worth recording

The spec's ruleset section did not anticipate paths-ignore on the pull_request trigger, which would have made .md-only PRs permanently unmergeable, including PRs editing the very DESCRIPTION.md and TAGS.md files the design depends on. That was found during planning and handled, but the spec never recorded it.

Acceptance criteria

  • Both errors corrected in the spec
  • The paths-ignore interaction documented
  • The bypass-actor finding written down clearly enough that nobody re-derives 15368 from the same misleading evidence

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions