Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client does not handle API rate limits #295

Open
f1gjam opened this issue Nov 25, 2024 · 0 comments
Open

Client does not handle API rate limits #295

f1gjam opened this issue Nov 25, 2024 · 0 comments

Comments

@f1gjam
Copy link

f1gjam commented Nov 25, 2024

After degbugging why suddenly some times getting commit data would fail. I realised I must be hitting the rate limite. I needed to debug

func (c *Client) doPaginatedRequest(req *http.Request, page *int, emptyResponse bool) (interface{}, error) {

to find that I was actually hitting the rate limit. It would be good to handle the api rate limit or at least pass back this information so that the end developer can manage the rate limit themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant