Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open text edit mode when double-click on textbox figure in Text tool #180

Open
MurzNN opened this issue Dec 20, 2020 · 4 comments
Open

Open text edit mode when double-click on textbox figure in Text tool #180

MurzNN opened this issue Dec 20, 2020 · 4 comments
Labels
question Further information is requested

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Dec 20, 2020

It isn't easy to understand how to edit already typed text when "Text" tool is selected. Will be good to make it better via auto opening text edit mode when user do a double-click on textbox figure, instead of placing new textbox figure.

Also will be good to auto-clean empty text figures (with zero width and empty string), which can be created too many via simple clicks when users forgot switch to Select tool from Text and try to select something.

@DamirPorobic
Copy link
Member

The problem is not as simple as you might think, a double click is at first a click and a click creates an item, then you detect the second click you would need to go back and remove the just created item which is already in the undo stack. Can be programmed but with some ugly code. Other Applications switch to select tool after drawing an item, in this case it's easy to work with the double click, this can now be done with the annotator too but getting both might be tricky.

@DamirPorobic DamirPorobic added the question Further information is requested label Dec 26, 2020
@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 28, 2020

The solution for double-click interception can be adding timeout after first single click, that will wait if second click happens, and if no - execute single-click action. This can be done always, or only when clicked under already exists text object.

Or solution, inspired by Inskcape, is always treat clicks under already exists text object as edits of previous object, instead of creating new object, maybe even this will be better for users.

@DamirPorobic
Copy link
Member

The first proposal is IMHO not a good solution, it would add delay for normal item adding which is probably the most often use case.

The second might be a possible solution but is going to prevent drawing items over items or forces you to start drawing on an empty area and move it over the next item. I think we should bring this to the discussion board and get some option from other users.

@DamirPorobic
Copy link
Member

Can you please test again, the Text Annotation Tool has been reimplemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants