Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault tolerant test for kruize local #1263

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

chandrams
Copy link
Contributor

Included a test to validate list experiments, list recommendations, list datasources, list metadata after kruize restart

@chandrams chandrams marked this pull request as ready for review August 29, 2024 08:55
@chandrams chandrams added this to the Kruize 0.0.25_rm Release milestone Aug 29, 2024
@chandrams chandrams changed the title Initial scripts for fault tolerant test for kruize local Fault tolerant test for kruize local Aug 29, 2024
Copy link
Contributor

@khansaad khansaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrams This seems to be working fine except at the end we're seeing test failure message.

Test took 403 seconds to complete
Local Monitoring Fault tolerant test failed! Check the logs for details

On checking the logs, found out that it's because of the error message coming while deploying autotune:

...
2024-09-0309:32:23.675 INFO [main][DataSourceCollection.java(53)]-Datasource found: prometheus-1
2024-09-0309:32:23.732 ERROR [main][DataSourceCollection.java(146)]-Datasource: prometheus-1 already exists!
...

I think we can change this to warning later on.

Also, all PR checks are failing due to this reason:


create performance profile status = 
Failed! Create performance profile failed. Status - 
########################################################################

Error: Process completed with exit code 1.

@chandrams
Copy link
Contributor Author

@khansaad - I did a rebase on mvp demo & restarted the PR checks, they pass now.

Copy link
Contributor

@khansaad khansaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@msvinaykumar msvinaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandrams chandrams merged commit f28496c into kruize:mvp_demo Sep 16, 2024
2 of 3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants