-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fault tolerant test for kruize local #1263
Conversation
ec3c300
to
3993172
Compare
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
4b0cf73
to
50b1ce8
Compare
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrams This seems to be working fine except at the end we're seeing test failure message.
Test took 403 seconds to complete
Local Monitoring Fault tolerant test failed! Check the logs for details
On checking the logs, found out that it's because of the error message coming while deploying autotune:
...
2024-09-0309:32:23.675 INFO [main][DataSourceCollection.java(53)]-Datasource found: prometheus-1
2024-09-0309:32:23.732 ERROR [main][DataSourceCollection.java(146)]-Datasource: prometheus-1 already exists!
...
I think we can change this to warning later on.
Also, all PR checks are failing due to this reason:
create performance profile status =
Failed! Create performance profile failed. Status -
########################################################################
Error: Process completed with exit code 1.
@khansaad - I did a rebase on mvp demo & restarted the PR checks, they pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Included a test to validate list experiments, list recommendations, list datasources, list metadata after kruize restart