Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all instances of x and y in the API where hRes and vRes would be more appropriate. #13

Open
DDR0 opened this issue Jun 14, 2019 · 1 comment
Open

Remove all instances of x and y in the API where hRes and vRes would be more appropriate. #13

DDR0 opened this issue Jun 14, 2019 · 1 comment
Assignees
@oskirby
Labels
design shortcoming This should work differently than it does.

Comments

@DDR0
Copy link
Contributor

DDR0 commented Jun 14, 2019

The video api, which is partially proxied through the control api, exposes several parameters for image width and height as x and y. These should be hRes and vRes or hOffset and vOffset, to be consistent with the control API.
@DDR0 DDR0 added the design shortcoming This should work differently than it does. label Jun 14, 2019
@oskirby
Copy link
Contributor

oskirby commented Jul 12, 2019

This is technically a bug against https://github.com/krontech/chronos-cli but changes will be slow in this regard since they also impact the Arago builds and I don't want to be making too many unnecessary changes to that ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskirby oskirby

Labels
design shortcoming This should work differently than it does.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DDR0 @oskirby