Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max/min values not reached #25

Open
neighthan opened this issue Jul 1, 2019 · 0 comments · May be fixed by #29
Open

Max/min values not reached #25

neighthan opened this issue Jul 1, 2019 · 0 comments · May be fixed by #29
Assignees

Comments

@neighthan
Copy link
Contributor

Depending on the height set for a chart (even if the y-axis labels are exactly the same), the appropriate values are not always reached (at least when these are the max / min values; I haven't tested enough to check others yet). E.g., using the Python version, everything looks fine in this first plot:

$ pplot 1 10 --height 9
   10.00  ┤╭ 
    9.00  ┤│ 
    8.00  ┤│ 
    7.00  ┤│ 
    6.00  ┤│ 
    5.00  ┤│ 
    4.00  ┤│ 
    3.00  ┤│ 
    2.00  ┤│ 
    1.00  ┼╯ 

but if we change the height to 8, even though we still achieve exactly the first and last values on the y-axis, it's shown that the first point is 2 instead of 1:

$ pplot 1 10 --height 8
   10.00  ┼╭ 
    9.00  ┤│ 
    8.00  ┤│ 
    7.00  ┤│ 
    6.00  ┤│ 
    5.00  ┤│ 
    4.00  ┤│ 
    3.00  ┤│ 
    2.00  ┤╯ 
    1.00  ┼  

If we increase the height, then we don't reach the max value anymore:

$ pplot 1 10 --height 10
   10.00  ┤  
    9.18  ┤╭ 
    8.36  ┤│ 
    7.55  ┤│ 
    6.73  ┤│ 
    5.91  ┤│ 
    5.09  ┤│ 
    4.27  ┤│ 
    3.45  ┤│ 
    2.64  ┤│ 
    1.82  ┤│ 
    1.00  ┼╯ 
@neighthan neighthan linked a pull request Jul 1, 2019 that will close this issue
@kroitor kroitor self-assigned this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants