Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional language codes #88

Open
krogenth opened this issue May 7, 2024 · 2 comments
Open

Add support for additional language codes #88

krogenth opened this issue May 7, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@krogenth
Copy link
Owner

krogenth commented May 7, 2024

Is your feature request related to a problem? Please describe.
Currently only en_US is supported. There are other languages out there that should realistically be supported.

Describe the solution you'd like
More locale json definitions should be added in G2DataGUI.UI.Common/Assets/Locales.

@krogenth krogenth added enhancement New feature or request good first issue Good for newcomers labels May 7, 2024
@krogenth
Copy link
Owner Author

krogenth commented May 7, 2024

For reference, see pr #87 for what was done to mitigate this issue. Reverting or altering those changes should be done for this task as well.

@krogenth
Copy link
Owner Author

krogenth commented May 7, 2024

For a list of culture/language codes, see: https://learn.microsoft.com/en-us/bingmaps/rest-services/common-parameters-and-types/supported-culture-codes

At minimum we should probably support:

  • de_de
  • en_GB
  • es_ES
  • es_MX
  • fr_FR
  • fr_CA
  • ja
  • ru

There's probably more, but this would be a good first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant