Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file = "relative_path_to_excluded_file" appears to be OS-specific #531

Open
mpilgrem opened this issue Oct 18, 2023 · 0 comments
Open

file = "relative_path_to_excluded_file" appears to be OS-specific #531

mpilgrem opened this issue Oct 18, 2023 · 0 comments

Comments

@mpilgrem
Copy link
Contributor

On Windows, I tried:

# Anti-pattern: Slow 'length' for Text
[[check]]
  id = "STAN-0208"
  file = "src/Stack/PackageDump.hs"
  type = "Exclude"

but that did not exclude what I wanted to be excluded. I had to specify:

# Anti-pattern: Slow 'length' for Text
[[check]]
  id = "STAN-0208"
  file = "src\\Stack\\PackageDump.hs"
  type = "Exclude"

I think that means that file-specific exclusions have to be stated twice in each .stan.toml file that is going to be used on both Windows and Unix-like operating systems. I assume the same is true for directory-specific exclusions.

It would be good if they only had to be specified once.
0rphee added a commit to 0rphee/haskell-language-server that referenced this issue Jan 9, 2024
@0rphee
Fix windows tests
7300fae 
See kowainik/stan#531
michaelpj added a commit to haskell/haskell-language-server that referenced this issue Jan 11, 2024
@0rphee @michaelpj
Use stan config files for stan plugin (#3904) (#3914)
034b33e 
* Bump stan

Needed in order to get the functions for getting the config, etc.

* Use stan config files for stan plugin (#3904)

* Add test case for .stan.toml configuration

* Fix windows tests

See kowainik/stan#531

---------

Co-authored-by: Michael Peyton Jones <[email protected]>
soulomoon added a commit to soulomoon/haskell-language-server that referenced this issue Jan 12, 2024
@soulomoon
Squashed commit of the following:
5091256 
commit 2fe2d70
Merge: 034b33e bea1fed
Author: fendor <[email protected]>
Date:   Thu Jan 11 16:05:34 2024 +0100

    Merge pull request haskell#3941 from fendor/enhance/cabal-no-diags-if-disabled

    Don't produce diagnostics if plugin is turned off

commit bea1fed
Merge: e9aab3c 034b33e
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Jan 11 13:54:12 2024 +0000

    Merge branch 'master' into enhance/cabal-no-diags-if-disabled

commit e9aab3c
Author: Fendor <[email protected]>
Date:   Wed Jan 10 17:18:39 2024 +0100

    Don't produce diagnostics if plugin is turned off

commit 034b33e
Author: 0rphee <[email protected]>
Date:   Thu Jan 11 02:53:11 2024 -0600

    Use stan config files for stan plugin (haskell#3904) (haskell#3914)

    * Bump stan

    Needed in order to get the functions for getting the config, etc.

    * Use stan config files for stan plugin (haskell#3904)

    * Add test case for .stan.toml configuration

    * Fix windows tests

    See kowainik/stan#531

    ---------

    Co-authored-by: Michael Peyton Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpilgrem