Skip to content

Commit b5a0f3c

Browse files
BILLyTheLiTTlehyperb1iss
BILLyTheLiTTle
authored and
hyperb1iss
committed
Fix several compiler warnings
Change-Id: I477f7f0dc37cc82028a3f1fa280dad1977f20efc
1 parent 5e1af17 commit b5a0f3c

25 files changed

+226
-220
lines changed

‎Superuser/src/com/koushikdutta/superuser/AboutFragment.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public Context getContext() {
2525
mWrapper = new ContextThemeWrapper(super.getContext(), value.resourceId);
2626
return mWrapper;
2727
}
28-
28+
2929
@Override
3030
protected void onCreate(Bundle savedInstanceState, View view) {
3131
super.onCreate(savedInstanceState, view);
@@ -38,7 +38,7 @@ protected void onCreate(Bundle savedInstanceState, View view) {
3838
}
3939
catch (NameNotFoundException e) {
4040
}
41-
41+
4242
addItem(R.string.about, new ListItem(getInternal(), getString(R.string.superuser), version, R.drawable.ic_launcher) {
4343
@Override
4444
public void onClick(View view) {
@@ -48,7 +48,7 @@ public void onClick(View view) {
4848
startActivity(i);
4949
}
5050
});
51-
51+
5252
addItem(R.string.about, new ListItem(getInternal(), "Koushik Dutta", "@koush", R.drawable.koush) {
5353
@Override
5454
public void onClick(View view) {
@@ -65,7 +65,7 @@ public void onClick(View view) {
6565

6666
}
6767
});
68-
68+
6969
final String uri = "http://github.com/koush/Superuser";
7070
addItem(R.string.about, new ListItem(getInternal(), "Github", uri, R.drawable.github) {
7171
@Override
@@ -86,7 +86,7 @@ public void onClick(View view) {
8686
i.setData(Uri.parse("market://details?id=com.koushikdutta.rommanager"));
8787
startActivity(i);
8888
}
89-
});
89+
});
9090
addItem(R.string.apps, new ListItem(getInternal(), "Helium", "Android's missing backup solution", R.drawable.carbon) {
9191
@Override
9292
public void onClick(View view) {
@@ -95,7 +95,7 @@ public void onClick(View view) {
9595
i.setData(Uri.parse("market://details?id=com.koushikdutta.backup"));
9696
startActivity(i);
9797
}
98-
});
98+
});
9999
addItem(R.string.apps, new ListItem(getInternal(), "DeskSMS", "Seamlessly text message from your email, browser, or instant messenger", R.drawable.desksms) {
100100
@Override
101101
public void onClick(View view) {

‎Superuser/src/com/koushikdutta/superuser/LogFragmentInternal.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -51,22 +51,22 @@ public LogFragmentInternal setUidPolicy(UidPolicy up) {
5151
this.up = up;
5252
return this;
5353
}
54-
54+
5555
int mListContentId;
5656
public void setListContentId(int id) {
5757
mListContentId = id;
5858
}
59-
59+
6060
public int getListContentId() {
6161
return mListContentId;
6262
}
63-
63+
6464
void onDelete() {
6565
}
66-
66+
6767
@Override
6868
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
69-
69+
7070
inflater.inflate(R.menu.policy, menu);
7171
MenuItem delete = menu.findItem(R.id.delete);
7272
delete.setOnMenuItemClickListener(new OnMenuItemClickListener() {
@@ -81,7 +81,7 @@ public boolean onMenuItemClick(MenuItem item) {
8181
}
8282
});
8383
}
84-
84+
8585
@Override
8686
protected int getListItemResource() {
8787
return R.layout.log_item;
@@ -90,12 +90,12 @@ protected int getListItemResource() {
9090
@Override
9191
protected void onCreate(Bundle savedInstanceState, View view) {
9292
super.onCreate(savedInstanceState, view);
93-
93+
9494
LayoutInflater inflater = (LayoutInflater)getContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
9595
getListView().addHeaderView(inflater.inflate(R.layout.policy_header, null));
96-
96+
9797
getFragment().setHasOptionsMenu(true);
98-
98+
9999
if (up == null) {
100100
Bundle bundle = getFragment().getArguments();
101101
if (bundle != null) {
@@ -107,7 +107,7 @@ protected void onCreate(Bundle savedInstanceState, View view) {
107107
}
108108
}
109109
}
110-
110+
111111
ArrayList<LogEntry> logs;
112112
java.text.DateFormat day = DateFormat.getDateFormat(getActivity());
113113
java.text.DateFormat time = DateFormat.getTimeFormat(getActivity());
@@ -116,7 +116,7 @@ protected void onCreate(Bundle savedInstanceState, View view) {
116116
icon.setImageDrawable(Helper.loadPackageIcon(getActivity(), up.packageName));
117117
TextView name = (TextView)view.findViewById(R.id.name);
118118
name.setText(up.name);
119-
119+
120120
((TextView)view.findViewById(R.id.uid_header)).setText(Integer.toString(up.desiredUid));
121121
((TextView)view.findViewById(R.id.command_header)).setText(TextUtils.isEmpty(up.command) ? getString(R.string.all_commands) : up.command);
122122
String app = up.username;
@@ -134,7 +134,7 @@ protected void onCreate(Bundle savedInstanceState, View view) {
134134
view.findViewById(R.id.policy_header).setVisibility(View.GONE);
135135
logs = SuperuserDatabaseHelper.getLogs(getActivity());
136136
}
137-
137+
138138
for (LogEntry log: logs) {
139139
final String date = time.format(log.getDate());
140140
String title = date;

‎Superuser/src/com/koushikdutta/superuser/LogNativeFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ public LogFragmentInternal createFragmentInterface() {
4444
public Context getContext() {
4545
return LogNativeFragment.this.getContext();
4646
}
47-
47+
4848
@Override
4949
void onDelete() {
5050
super.onDelete();
5151
LogNativeFragment.this.onDelete(getListContentId());
5252
}
5353
};
5454
}
55-
55+
5656
@Override
5757
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
5858
return super.onCreateView((LayoutInflater)getContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE), container, savedInstanceState);

‎Superuser/src/com/koushikdutta/superuser/MainActivity.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public MainActivity() {
5151
public PolicyFragmentInternal getFragment() {
5252
return (PolicyFragmentInternal)super.getFragment();
5353
}
54-
54+
5555
@Override
5656
public boolean onCreateOptionsMenu(Menu menu) {
5757
MenuInflater mi = new MenuInflater(this);
@@ -64,7 +64,7 @@ public boolean onMenuItemClick(MenuItem item) {
6464
return true;
6565
}
6666
});
67-
67+
6868
return super.onCreateOptionsMenu(menu);
6969
}
7070

@@ -109,7 +109,7 @@ void doEntry(ZipOutputStream zout, String entryName, String dest) throws IOExcep
109109
in.close();
110110
zf.close();
111111
}
112-
112+
113113
public void run() {
114114
try {
115115
File zip = getFileStreamPath("superuser.zip");
@@ -167,7 +167,7 @@ public void run() {
167167
}
168168
}.start();
169169
}
170-
170+
171171
void doSystemInstall() {
172172
final ProgressDialog dlg = new ProgressDialog(this);
173173
dlg.setTitle(R.string.installing);
@@ -212,7 +212,7 @@ public void run() {
212212
AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.this);
213213
builder.setPositiveButton(android.R.string.ok, null);
214214
builder.setTitle(R.string.install);
215-
215+
216216
if (error) {
217217
builder.setMessage(R.string.install_error);
218218
}
@@ -225,7 +225,7 @@ public void run() {
225225
};
226226
}.start();
227227
}
228-
228+
229229
void doInstall() {
230230
AlertDialog.Builder builder = new AlertDialog.Builder(this);
231231
builder.setTitle(R.string.install);
@@ -247,11 +247,11 @@ public void onClick(DialogInterface dialog, int which) {
247247
});
248248
builder.create().show();
249249
}
250-
250+
251251
private void saveWhatsNew() {
252252
Settings.setString(this, "whats_new", WHATS_NEW);
253253
}
254-
254+
255255
// this is intentionally not localized as it will change constantly.
256256
private static final String WHATS_NEW = "Added support for Android 4.3.";
257257
protected void doWhatsNew() {
@@ -278,12 +278,12 @@ public void onClick(DialogInterface dialog, int which) {
278278
protected void onCreate(Bundle savedInstanceState) {
279279
Settings.applyDarkThemeSetting(this, R.style.SuperuserDarkActivity);
280280
super.onCreate(savedInstanceState);
281-
281+
282282
if (Settings.getBoolean(this, "first_run", true)) {
283283
saveWhatsNew();
284284
Settings.setBoolean(this, "first_run", false);
285285
}
286-
286+
287287
final ProgressDialog dlg = new ProgressDialog(this);
288288
dlg.setTitle(R.string.superuser);
289289
dlg.setMessage(getString(R.string.checking_superuser));

0 commit comments

Comments
 (0)