-
Notifications
You must be signed in to change notification settings - Fork 4
/
Copy pathChangeLog
1527 lines (1067 loc) · 56.9 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
commit 684cf4a5e0e84a1367690d7ecf4882cbdf4f3228
Author: Prem Karat <[email protected]>
Date: Thu Jun 30 07:29:20 2011 -0400
mount.nfs: Fix for the bug in v1.2.4 that breaks mount.nfs
commit 30ebf047 failed to include these changes that breaks mount.nfs.
mount.nfs will continue to work fine with these changes
Signed-off-by: Steve Dickson <[email protected]>
commit 057d2add27d1e05fed3ae7206ee043b6c1fda45a
Author: NeilBrown <[email protected]>
Date: Tue Jun 28 13:24:33 2011 -0400
Do not compile unnecessary files when the libmount code is enable
Signed-off-by: Steve Dickson <[email protected]>
commit 30ebf04700654deddbf5f57d95e84ec69cea8610
Author: Prem Karat <[email protected]>
Date: Tue Jun 28 11:53:40 2011 -0400
mount.nfs: Don't hard code source and destination
Currently souce and destination parameters should be passed as first and
second paramter while using mount.nfs. This patch allows them to be passed
anywhere while mounting.
Current functionality is
mount.nfs source destn -o <options>
This patch will allow to do this
mount.nfs -o <options> source destn
or
mount.nfs -o <options> source -o <options> destn
Signed-off-by: Prem Karat <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit b3e190c4adfc9ec47567c968bd000d282d07b05e
Author: NeilBrown <[email protected]>
Date: Tue Jun 28 11:36:31 2011 -0400
mount: improve signal management when locking mtab
As mount.nfs can run setuid it must be careful about how the user can
interact with in. In particular it needs to ensure it does not
respond badly to any signals that the user might be able to generate.
This is particularly an issue while updating /etc/mtab (when that is
not linked to /proc/mounts). If the user can generate a signal which
kills mount.nfs while /etc/mtab is locked, then it will leave the file
locked, and could possibly corrupt mtab (particularly if 'ulimit 1'
was previously issued).
Currently lock_mtab does set some handlers for signals, but not
enough. It arranges for every signal up to (but not including)
SIGCHLD to cause mount.nfs to unlock mdadm promptly exit ... even if
the default behaviour would be to ignore the signal. SIGALRM is
handled specially, and signals after SIGCHLD are left with their
default behaviour. This includes for example SIGXFSZ which can be
generated by the user running "ulimit 1".
So: change this so that some signals are left unchanged, SIGALRM is
handled as required, and all signals that the user can generate are
explicitly ignored.
The remainder still cause mount.nfs to print a message, unlock mtab, and
exit.
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit a99b7846e2abec5e26ab6b764b921d79559e0a0f
Author: J. Bruce Fields <[email protected]>
Date: Mon Jun 27 12:31:07 2011 -0400
mountd: move fsidtype-specific code to helpers
Now we can move these big switch statements into helper functions.
Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit e6559fd0b7b63f5d152d33d598dc74d78df30ecb
Author: J. Bruce Fields <[email protected]>
Date: Mon Jun 27 12:30:36 2011 -0400
mountd: gather fsid information into one struct
A large part of nfsd_fh() is concerned with extracting
fsid-type-specific information from the fsid, then matching that
information with information from the export list and the filesystem.
Moving all that information into one struct will allow some further
simplifications.
Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 13a0a61d037f2cc09e7997a96ce5822b9317883b
Author: J. Bruce Fields <[email protected]>
Date: Mon Jun 27 12:29:51 2011 -0400
mountd: prefer explicit subexports over crossmnt parents
If a parent is exported with crossmnt, and if a child is also explicitly
exported, then both exports could potentially produce matches in this
loop; that isn't a bug.
Instead of warning and ignoring the second match we find, we should
instead prefer whichever export is deeper in the tree, so that
children's options can override those of their parents.
Reported-by: Olga Kornievskaia <[email protected]>
Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit f8d26c1db9a260597828685c7f62e1b29e78285f
Author: Jeff Layton <[email protected]>
Date: Wed Jun 22 15:52:55 2011 -0400
manpage: add section on character class matches to exports(5)
Signed-off-by: Jeff Layton <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit cb6676aea5bcfcbeaf868e53177eff51f4efe9a8
Author: James Pearson <[email protected]>
Date: Wed Jun 22 15:51:47 2011 -0400
nfs-utils: remove possibly false statement from exports.man
A very minor change suggested by J. Bruce Fields <[email protected]>
to remove the statement that exporting to a single host or IP address is
the "most common format" - as it probably isn't.
Signed-off-by: James Pearson <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 7d71ff8e3825a7f8c2d5c9b5b9344e95e7aa1392
Author: Jeff Layton <[email protected]>
Date: Wed Jun 22 15:51:02 2011 -0400
manpage: add info about IPv6 configuration to exports(5)
The parts of the exports(5) manpage that discuss IP addressing neglect
IPv6 configuration. Update to include info on how to export to IPv6
subnets and addresses, and add a line demonstrating that to the EXAMPLE
section.
Signed-off-by: Jeff Layton <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 545ea1098089d6396d5a70111ec231c4de967faa
Author: Benny Halevy <[email protected]>
Date: Wed Jun 22 15:44:17 2011 -0400
nfsstat: reorder nfs4 stats for 2.6.39
Signed-off-by: Benny Halevy <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit c7ce7a4674ad446bee4dd3baf90155ce6b216816
Author: Mi Jinlong <[email protected]>
Date: Wed Jun 22 15:41:27 2011 -0400
libexport.a: fix using bad index for loop at cltsetup()
In cltsetup(), when checking the address, use clp's naddr for index,
instead of cltarg's naddr, which it's always zero there.
Signed-off-by: Mi Jinlong <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit b50ad13298b3e9519a9bdecb8c146c9ecf39cef8
Author: Jeff Layton <[email protected]>
Date: Wed Jun 22 14:51:38 2011 -0400
nfs: fix host_reliable_addrinfo
According to Neil Brown:
The point of the word 'reliable' is to check that the name we get
really does belong to the host in question - ie that both the
forward and reverse maps agree.
But the new code doesn't do that check at all. Rather it simply
maps the address to a name, then discards the address and maps the
name back to a list of addresses and uses that list of addresses as
"where the request came from" for permission checking.
This bug is exploitable via the following scenario and could allow an
attacker access to data that they shouldn't be able to access.
Suppose you export a filesystem to some subnet or FQDN and also to a
wildcard or netgroup, and I know the details of this (maybe
showmount -e tells me) Suppose further that I can get IP packets to
your server..
Then I create a reverse mapping for my ipaddress to a domain that I
own, say "black.hat.org", and a forward mapping from that domain to
my IP address, and one of your IP addresses.
Then I try to mount your filesystem. The IP address gets correctly
mapped to "black.hat.org" and then mapped to both my IP address and
your IP address.
Then you search through all of your exports and find that one of the
addresses: yours - is allowed to access the filesystem.
So you create an export based on the addrinfo you have which allows
my IP address the same access as your IP address.
Fix this by instead using the forward lookup of the hostname just to
verify that the original address is in the list. Then do a numeric
lookup using the address and stick the hostname in the ai_canonname.
Reviewed-by: NeilBrown <[email protected]>
Signed-off-by: Jeff Layton <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 7235a2164aabfd8dba1f7e1577047bda45053db0
Author: James Pearson <[email protected]>
Date: Tue Jun 7 16:25:13 2011 -0400
exports: Clearly Defining Exports Priorities
Added some verbiage to the exports(5) man page
that clearly explains the precedence around
how exports will work with regard to netgroups.
Signed-off-by: Steve Dickson <[email protected]>
commit a36f2437caffb23c68fdc0900544d59198bd52b6
Author: Neil Brown <[email protected]>
Date: Tue Jun 7 13:18:55 2011 -0400
Document "-n" for svcgssd
The svcgssd man page doesn't mention the "-n" flag.
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 40aed2c3fb5164195a9975ae7f15ebd4b992839d
Author: Pavel Shilovsky <[email protected]>
Date: Tue Jun 7 13:18:13 2011 -0400
mountd: Fix missing varialble assignment in auth_unix_gid
When we get into auth_unix_gid at the second time, groups_len
is not 0 and ngroups variable leave as 0. Then we use ngroups
in getgrouplist that fails in this case. This patch fixes it.
Signed-off-by: Pavel Shilovsky <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 8935933dedcd820c2fb3dddff8b79fd5841dc217
Author: Benny Halevy <[email protected]>
Date: Mon May 23 08:37:17 2011 -0400
nfsstat: reorder nfs4 stats for 2.6.38 and up
match order in 2.6.38, 2.6.39 (-rc3) and development tree
while at it, get rid of obsolete ds_write and ds_commit
Signed-off-by: Benny Halevy <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 27dcd8a775024160e741cce53e4a402eaac3501d
Author: NeilBrown <[email protected]>
Date: Mon May 23 08:23:51 2011 -0400
supress socket error when address family is not supported
From: Suresh Jayaraman <[email protected]>
It was observed that when ipv6 module was not loaded and cannot be auto-loaded,
when starting NFS server, the following error occurs:
"rpc.nfsd: unable to create inet6 TCP socket: errno 97 (Address
family not supported by protocol)"
This is obviously a true message, but does not represent an "error" when ipv6
is not enabled. Rather, it is an expected condition. As such, it can be
confusing / misleading / distracting to display it in this scenario.
This patch instead of throwing error when a socket call fails with
EAFNOSUPPORT, makes it as a NOTICE.
Signed-off-by: Suresh Jayaraman <[email protected]>
Signed-off-by: Neil Brown <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 7a802337bfc92d0b30fe94dbd0fa231990a26161
Author: NeilBrown <[email protected]>
Date: Mon May 23 08:19:57 2011 -0400
Remove risk of nfs_addmntent corrupting mtab
nfs_addmntent is used to append directly to /etc/mtab.
If the write partially fail, e.g. due to RLIMIT_FSIZE,
truncate back to original size and return an error.
See also https://bugzilla.redhat.com/show_bug.cgi?id=697975
(CVE-2011-1749) CVE-2011-1749 nfs-utils: mount.nfs fails to anticipate RLIMIT_FSIZE
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 56f537535190d034039570bafd9a0de71b79b8f1
Author: Ben Myers <[email protected]>
Date: Mon May 23 08:07:00 2011 -0400
exportfs: getexportent interprets -test-client- as default options
With commit 1374c3861abdc66f3a1410e26cc85f86760b51dd Neil added a
-test-client- export to test the exportability of filesystems when exportfs
is run. When using the old cache controls (i.e. /proc/fs/nfsd is not
mounted) exportfs will read /proc/fs/nfs/exports to process existing
exports and find these test client entries. The dash at the beginning of
-test-client- will be cause getexportent to look for default options in the
rest of the string, which test-client- will not match:
exportfs: /proc/fs/nfs/exports:1: unknown keyword "test-client-(rw"
This patch resolves that problem (as Steve suggested) by not processing any
default options if we are reading the list of existing exports from the
kernel. Default options are converted to individual exports by exportfs so
the kernel won't have any regardless.
Signed-off-by: Ben Myers <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit c8e802c036a3f0fcd4481dae8b3ec09fb71f4118
Author: Jim Rees <[email protected]>
Date: Wed May 18 12:42:02 2011 -0400
Removed compilation warnings from mountd/cache.c
Commit 5604b35a6 introduced a number of missing initializer
warnings that were missed. This patch removes those warnings.
Signed-off-by: Steve Dickson <[email protected]>
commit 68f7938c85258a8c54b13169dcdeae61cc1bf286
Author: Steve Dickson <[email protected]>
Date: Tue Apr 26 13:32:35 2011 -0400
nfsstat: Output headings mislabled
The badclnt and badauth headers were reversed
when the server side rpc stats (-s -o rpc) were
displayed.
Signed-off-by: Steve Dickson <[email protected]>
commit 2e4a7e9b50a641dc8640a5dd911ee4a2f0b2c073
Author: Steve Dickson <[email protected]>
Date: Tue Apr 19 12:31:30 2011 -0400
rpc.svcgssd: Segmentation fault on error
Commit 544ed73d introduced a regression that caused
rpc.svcgssd to seg fault on "Wrong principal in request"
errors in gss_accept_sec_context()
Signed-off-by: Steve Dickson <[email protected]>
commit 5604b35a61e22930873ffc4e9971002f578e7978
Author: Sean Finney <[email protected]>
Date: Tue Apr 19 11:04:35 2011 -0400
nfs-utils: Increase the stdio file buffer size for procfs files
Previously, when writing to /proc/net/rpc/*/channel, if a cache line
were larger than the default buffer size (likely 1024 bytes), mountd
and svcgssd would split writes into a number of buffer-sized writes.
Each of these writes would get an EINVAL error back from the kernel
procfs handle (it expects line-oriented input and does not account for
multiple/split writes), and no cache update would occur.
When such behavior occurs, NFS clients depending on mountd to finish
the cache operation would block/hang, or receive EPERM, depending on
the context of the operation. This is likely to happen if a user is a
member of a large (~100-200) number of groups.
Instead, every fopen() on the procfs files in question is followed by
a call to setvbuf(), using a per-file dedicated buffer of
RPC_CHAN_BUF_SIZE length.
Really, mountd should not be using stdio-style buffered file operations
on files in /proc to begin with. A better solution would be to use
internally managed buffers and calls to write() instead of these stdio
calls, but that would be a more extensive change; so this is proposed
as a quick and not-so-dirty fix in the meantime.
Signed-off-by: Sean Finney <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 9274e94db85bac04e170414cb8e0f4be271cde90
Author: Sean Finney <[email protected]>
Date: Tue Apr 19 11:05:47 2011 -0400
mountd: Use a dynamic buffer for storing lists of gid's
Previously, in auth_unix_gid, group lists were stored in an array of
hard-coded length 100, and in the situation that the group lists for a
particular call were too large, the array was swapped with a dynamically
allocated/freed buffer. For environments where users are commonly in
a large number of groups, this isn't an ideal approach.
Instead, use malloc/realloc to grow the list on an as-needed basis.
Signed-off-by: Sean Finney <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit a99269230a0e77e7bed4fa31c9547f0d61c7f206
Author: Karel Zak <[email protected]>
Date: Wed Apr 6 12:39:21 2011 -0400
mount: add --enable-libmount-mount
This patch allows to link mount.nfs with libmount from util-linux >=
v2.19. The new libmount based code is enabled by CONFIG_LIBMOUNT and
is stored in mount_libmount.c. The old code is not affected by this
change.
The libmount does not have officially stable API yet, so the
--enable-libmount-mount is marked as experimental in the configure
help output.
The ./configure option is the same as we use in util-linux to enable
support for libmount in mount(8).
The addr= (and some other options necessary for remount/umount) are
stored to /etc/mtab or to /dev/.mount/utab. The utab file is *private*
libmount file. It's possible that some mount options (for example
user=) will be moved to kernel, so the utab will not be necessary.
About libmount:
* supports systems without and with regular /etc/mtab
* does not store VFS and FS mount options in userspace
* manages user= option and evaluate permissions
* parses VFS mount options and generate MS_* flags
* parses /etc/{fstab,mtab}, /proc/mounts or /proc/self/mountinfo
* long-term goal is to use the same code in all mount.<type> helpers
Note, use
LIBMOUNT_DEBUG=0xffff mount.nfs foo:/path /path
to debug the library.
On systems with util-linux v2.19 the findmnt(8) command uses libmount
to list all/selected mount points:
$ findmnt /path
$ findmnt --mtab /path
the --mtab appends userspace mount options (e.g. user=) to the output.
CC: Chuck Lever <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit c01e5ca6179b8f5b041605d9bbd75a0f76812d54
Author: Karel Zak <[email protected]>
Date: Wed Apr 6 11:36:40 2011 -0400
mount: move generic functions to utils.c and network.c
Move generic code that could be shared between standard mount.nfs and
libmount version to utils.c and network.c.
CC: Chuck Lever <[email protected]>
Signed-off-by: Karel Zak <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit d6c1b35c6b40243bfd6fba2591c9f8f2653078c0
Author: Kevin Coffman <[email protected]>
Date: Wed Apr 6 11:25:03 2011 -0400
nfs-utils: Add support to svcgssd to limit the negotiated enctypes
Recent versions of Kerberos libraries negotiate and use
an "acceptor subkey". This negotiation does not consider
that a service may have limited the encryption keys in its
keytab. A patch (http://src.mit.edu/fisheye/changelog/krb5/?cs=24603)
has been added to the MIT Kerberos code to allow an application
to indicate that it wants to limit the encryption types negotiated.
(This functionality has been available on the client/initiator
side for a while. The new patch adds this support to the
server/acceptor side.)
This patch adds support to read a recently added nfsd
proc file to determine the encryption types supported by
the kernel and calls the function to limit encryption
types negotiated for the acceptor subkey.
Signed-off-by: Kevin Coffman <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 73840ef610accf4cf667427bc64805377c0d8394
Author: Chuck Lever <[email protected]>
Date: Wed Apr 6 10:53:57 2011 -0400
exports: add a configurable time-to-live for the kernel cache entries
From: Trond Myklebust <[email protected]>
The fedfs ldap server will specify a ttl for its entries.
Signed-off-by: Trond Myklebust <[email protected]>
This is a refactoring change only. There should be no change in
behavior.
Original patch had updates to utils/mountd/junctions.c, which no
longer exists. These are not included here.
Create a macro for the default cache TTL, which is used in several
places besides the export cache.
Make e_ttl unsigned.
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 38e4c685410885a6d464ddd44eff4fd5e7f8459f
Author: Chuck Lever <[email protected]>
Date: Wed Apr 6 10:49:52 2011 -0400
statd: Remove vestigial "-w" option from man page synopsis
The synopsis of rpc.statd in its man page lists "-w" as a valid
option. There is currently no support in the source code for a "-w"
option.
BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=199
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit b57cd77c13831051ad974ae027d96cd88a8d0c59
Author: Chuck Lever <[email protected]>
Date: Wed Apr 6 10:48:38 2011 -0400
mount.nfs: Don't leak socket in nfs_ca_sockname()
Ensure the test socket is always closed before nfs_ca_sockname()
returns. Otherwise it's orphaned.
BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=197
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 502eef09d8050ffb87d394397c2780e1ef042d68
Author: Steve Dickson <[email protected]>
Date: Wed Apr 6 10:46:06 2011 -0400
Removed a warning from v4root.c
v4root.c:176:9: warning: variable 'ret' set but not used
Signed-off-by: Steve Dickson <[email protected]>
commit c2fa189a0467c25666f014cf9ff2576a9f54d682
Author: Steve Dickson <[email protected]>
Date: Wed Apr 6 10:39:10 2011 -0400
Removed a warning from exportfs.c
exportfs.c:280:29: warning: 'exp' may be used uninitialized in this function
Signed-off-by: Steve Dickson <[email protected]>
commit b98ae9df8c4904289c9390288325058b24caa423
Author: Steve Dickson <[email protected]>
Date: Wed Apr 6 10:36:30 2011 -0400
Removed a warning from conffile.c
conffile.c:258:19: warning: 'j' may be used uninitialized in this function
Signed-off-by: Steve Dickson <[email protected]>
commit 012e1a4bf2a002e8cd4d5be3478bfa20a91cbfed
Author: Masatake YAMATO <[email protected]>
Date: Mon Mar 7 08:36:19 2011 -0500
Update man pages for /etc/exports.d
Man page updates for /etc/exports.d.
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit c7427b57e2be8ef0d57ad0618d4590c062b130f5
Author: Masatake YAMATO <[email protected]>
Date: Mon Mar 7 08:18:51 2011 -0500
Read /etc/exports.d/*.export as extra export files
This patch adding a capability to read /etc/exports.d/*.exports as
extra export files to exportfs.
If one wants to add or remove an export entry in a script, currently
one may have to use sed or something tool for adding or removing the
line for the entry in /etc/exports file.
With the patch, adding and removing an entry from a script is much
easier.
cat<<EOF... or mv can be used for adding. rm can be used for removing.
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit edb9b7f2ab9806afb9af31eabeb505fe454c51df
Author: Steve Dickson <[email protected]>
Date: Sat Mar 5 16:17:01 2011 -0500
Cleaned up a warning in rpcdispatch.c
rpcdispatch.c:40:20: warning: comparison between signed and unsigned
integer expressions
Signed-off-by: Steve Dickson <[email protected]>
commit 930323817b61877d61fb8ef57229013daa2e6091
Author: Steve Dickson <[email protected]>
Date: Sat Mar 5 16:13:01 2011 -0500
mount: Remove MOUNT_CONFIG warnings
The following changes are needed to remove compile warnings when
MOUNT_CONFIG is not defined
Signed-off-by: Steve Dickson <[email protected]>
commit 3ef3dc8f1e87ba7a6eaa3c2a6965aff6c80ba414
Author: Chuck Lever <[email protected]>
Date: Thu Mar 3 17:26:33 2011 -0500
mount: Recognize zero as a valid value for the port= option
While zero is not a valid IP port number, zero does represent a valid
value for "port=". It means "query rpcbind to discover the actual
non-zero port number to use". So the parsing functions that handle
"port=" should not flag zero as an invalid value.
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit b3a4dbfb61dad59829f5191d727267b2ea45937a
Author: Mi Jinlong <[email protected]>
Date: Wed Feb 9 11:29:42 2011 -0500
Gssd: modify wrong err message at handle_gssd_upcall
Modify wrong err message at handle_gssd_upcall when
sscanf encryption types fail.
Signed-off-by: Mi Jinlong <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 45e4597bd570ed40221f51887cde7d7f096f55e7
Author: Jason Gunthorpe <[email protected]>
Date: Wed Feb 9 11:27:19 2011 -0500
Support AD style kerberos automatically in rpc.gss
An Active Directory KDC will only grant a TGT for UPNs, getting
a TGT for SPNs is not possible:
$ kinit -k host/[email protected]
kinit: Client not found in Kerberos database while getting initial
credentials
The correct thing to do for machine credentials is to get a TGT
for the computer UPN <HOSTNAME>$@REALM:
$ kinit -k IB5\$
$ klist
12/22/10 11:43:47 12/22/10 21:43:47 krbtgt/[email protected]
Samba automatically creates /etc/krb5.keytab entry for the computer UPN,
this patch makes gssd_refresh_krb5_machine_credential prefer it above
the SPNs if it is present.
The net result is that nfs client works automatically out of the box
if samba has been used to setup kerberos via 'net ads join' 'net ads
keytab create'
Tested using Windows Server 2003 R2 as the AD server.
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 730f6986f86873513fa021a450eb55ccd0f2fbff
Author: Steve Dickson <[email protected]>
Date: Wed Jan 26 07:49:19 2011 -0500
Fixed segfault in rpc.mountd
A unallocated piece of memory, instead of a NULL point, was being
used to initialize a ->next point in the mount link list which
caused a segfault after a few remote accesses via the showmount
command.
Signed-off-by: Steve Dickson <[email protected]>
commit 544ed73d5ab27c1390833d5cf93b9585c151667d
Author: Steve Dickson <[email protected]>
Date: Fri Jan 14 10:12:28 2011 -0500
Improve debugging in svcgssd
Added in gss_display_error() which translates the GSS error into the
actual GSS macro name. Currently only the translation of these errors
are logged. Since those translations are buried deep in the kerberos
library code, having the actual GSS macro name makes it easier to
follow the code.
Moved the nfs4_init_name_mapping() call into main() so if debug is
enabled the DNS name and realms will be logged during start up.
Signed-off-by: Steve Dickson <[email protected]>
commit 57be18b9ab08148a1cc9d5af588119885720be8b
Author: Mi Jinlong <[email protected]>
Date: Tue Jan 4 11:16:45 2011 -0500
libnsm.a: modify return value to false from 0 at nsm_drop_privileges()
At nsm_drop_privileges(), for improving readability, unify
the return value.
Signed-off-by: Mi Jinlong <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 5c498280fd9353ded3ea169841079bdae23418e2
Author: Chuck Lever <[email protected]>
Date: Mon Dec 13 14:50:45 2010 -0500
libnsm.a: sm-notify sometimes ignores monitored hosts
Monitored host information is stored in files under /var/lib/nfs.
When visiting entries in the monitored hosts directory, libnsm.a
examines the value of dirent.d_type to determine if an entry is a
regular file.
According to readdir(3), the d_type field is not supported by all
file system types. My root file system happens to be one where d_type
isn't supported. Typical installations that use an ext-derived root
file system are not exposed to this issue, but those who use xfs, for
instance, are.
On such file systems, not only are remote peers not notified of
reboots, but the NSM state number is never incremented. A statd warm
restart would not re-monitor any hosts that were monitored before
the restart.
When writing support/nsm/file.c, I copied the use of d_type from the
original statd code, so this has likely been an issue for some time.
Replace the use of d_type in support/nsm/file.c with a call to
lstat(2). It's extra code, but is guaranteed to work on all file
system types.
Note there is a usage of d_type in gssd. I'll let gssd and rpcpipefs
experts decide whether that's worth changing.
Fix for:
https://bugzilla.linux-nfs.org/show_bug.cgi?id=193
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 089df7c754d9ebab0a7b804f396626ac95fee2e6
Author: Chuck Lever <[email protected]>
Date: Mon Dec 13 14:47:42 2010 -0500
libnsm.a: Replace __attribute_noinline__
Replace the __attribute_noinline__ form with
__attribute__((__noinline__)).
Even though the compiler didn't complain about __attribute_malloc__,
also replace those in order to maintain consistent style throughout the
source file.
Fix for:
https://bugzilla.linux-nfs.org/show_bug.cgi?id=194
Reported-by: "Gabor Z. Papp" <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 7869a76207d3f4b3bd4ab57b4a7a8807ac2ff0c6
Author: Chuck Lever <[email protected]>
Date: Mon Dec 13 14:36:15 2010 -0500
sm-notify: Make use of AI_NUMERICSERV conditional
Gabor Papp reports nfs-utils-1.2.3 doesn't build on his system that
uses glibc-2.2.5:
make[3]: Entering directory
`/home/gzp/src/nfs-utils-1.2.3/utils/statd'
gcc -DHAVE_CONFIG_H -I. -I../../support/include -D_GNU_SOURCE -Wall
-Wextra -Wstrict-prototypes -pipe -g -O2 -MT sm-notify.o -MD
-MP -MF .deps/sm-notify.Tpo -c -o sm-notify.o sm-notify.c
sm-notify.c: In function 'smn_bind_address':
sm-notify.c:247: error: 'AI_NUMERICSERV' undeclared (first use in this
function)
sm-notify.c:247: error: (Each undeclared identifier is reported only
once
sm-notify.c:247: error: for each function it appears in.)
make[3]: *** [sm-notify.o] Error 1
According to the getaddrinfo(3) man page, AI_NUMERICSERV is available
only since glibc 2.3.4. getaddrinfo(3) seems to convert strings
containing a number to the right port value without the use of
AI_NUMERICSERV, so I think we can survive on older glibc's without it.
It will allow admins to specify service names as well as port numbers
on those versions.
There are uses of AI_NUMERICSERV in gssd and in nfs_svc_create(). The
one in nfs_svc_create() is behind HAVE_LIBTIRPC, and the other is a
issue only for those who want to deploy Kerberos -- likely in both
cases, a more modern glibc will be present. I'm going to leave those
two.
Fix for:
https://bugzilla.linux-nfs.org/show_bug.cgi?id=195
Reported-by: "Gabor Z. Papp" <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit e8dbaddc8465dcd07b53f8e80a537703dd0248ca
Author: Sid Moore <[email protected]>
Date: Fri Dec 3 09:19:06 2010 -0500
rpc.mountd: Checking RPC Procedure ID before process it
Signed-off-by: Steve Dickson <[email protected]>
commit 3c6973c595d62dc6452967d50ae8abe69f9f8bad
Author: Mi Jinlong <[email protected]>
Date: Mon Nov 29 10:59:10 2010 -0500
libnfs.a: fix a bug when parse section's arg
When parsing section's arg at configure file, the pointer
should stop when fetch ']', and give the warning message.
Signed-off-by: Steve Dickson <[email protected]>
commit 86f7be64cafd17d4a3f164603484eaedb4757431
Author: Harshula Jayasuriya <[email protected]>
Date: Mon Nov 22 11:22:31 2010 -0500
nfs-utils: nfsstat: has_stats() does not function correctly for NFSv4 client stats
The NFSv4 client procs/ops in "struct rpc_procinfo nfs4_procedures" is
used to generate the NFS client stats interface:
------------------------------------------------------------
net 0 0 0 0
rpc 15 0 0
proc2 18 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
proc3 22 0 2 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 2 1 0
proc4 42 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0
0 0 0
0 0 0 0 0 0 0
------------------------------------------------------------
Note, for proc4, the number 42. That is the number of stats that follow
on the same line. Currently nfsstat's has_stats() relies on this number
to be equal to CLTPROC4_SZ. Unfortunately this is not the case. I have
changed has_stats() not to rely on these two values being equal. This
should also allow nfsstat to work with different kernel versions that
expose a different number of NFS client ops.
* Fix has_stats()
* Stop print_clnt_list() printing server stats!
* Describe the option -3 and -4 completely in the nfsstat manpage.
Signed-off-by: Harshula Jayasuriya <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 0868dcccb9a3bf3d022a32ff31311fe371484e77
Author: Steve Dickson <[email protected]>
Date: Sat Nov 20 15:01:21 2010 -0500
Enable nfsidmap to compile
Only enable the compilation of nfsidmap when libnfsidmap support it.
Signed-off-by: Steve Dickson <[email protected]>
commit 6f07548141e710767d425e119d9823691293771d
Author: Bryan Schumaker <[email protected]>
Date: Fri Nov 19 12:01:10 2010 -0500
Add the new nfsidmap program
This patch adds the nfsidmap program to nfs-utils. This program is
called by the nfs idmapper through request-keys to map between
uid / user name and gid / group name.
Signed-off-by: Bryan Schumaker <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 409487978593de13ae36be0ee56d8111ad6b3319
Author: Steve Dickson <[email protected]>
Date: Mon Nov 22 11:33:37 2010 -0500
Removed a couple warnings from utils/mount/stropts.c
stropts.c:740:6: warning: 'ret' may be used uninitialized in this function
stropts.c:653:6: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Steve Dickson <[email protected]>
commit f4968a724c1d4162a8e2b9f6a19c460cc56c95f7
Author: Chuck Lever <[email protected]>
Date: Fri Oct 29 12:56:21 2010 -0400
nfs(5): Document remount behavior
It appears that, for a long while, NFS "remount" mounts have
completely wiped the existing mount options in /etc/mtab for a given
mount point. This is a problem for umount.nfs, since it reads its
options out of /etc/mtab to find out how to do the unmount.
The mount(8) command provides the NFS mount subcommand with the mount
options to perform the remount. There are four cases to consider:
1. Both the device and mount directory are specified on the
command line, and the target mount point is in /etc/fstab
2. Only one of the device and mount directory is specified on
the command line, and the target mount point is in
/etc/fstab
3. Both the device and mount directory are specified on the
command line, and the target mount point is not in /etc/fstab
4. Only one of the device and mount directory is specified on
the command line, and the target mount point is not in
/etc/fstab
Currently only case 4 works correctly. In that case, mount(8)
provides the correct set of mount options to the mount.nfs
subcommand and it can update /etc/mtab correctly.
Cases 1 and 3 replace all mount options in /etc/mtab with the options
provided on the command line during a remount. Case 2 replaces the
mount options in /etc/mtab with a mix of options from /etc/fstab and
/etc/mtab.
Cases 1 and 3 are historical behavior. Basically this is a formal
interface to allow administrators to replace the mount options in
/etc/mtab completely, instead of merging in new ones. The present
patch documents that behavior in nfs(5), and provides best practice
for remounting NFS mount points.
There are near-term plans to address case 2 by fixing mount(8)
(provided by utils-linux-ng in most distributions).
This is a partial fix for:
https://bugzilla.linux-nfs.org/show_bug.cgi?id=188
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit 6d1a82b005994f759f2c847c0354413a24643da5
Author: Chuck Lever <[email protected]>
Date: Thu Oct 28 13:15:22 2010 -0400
nfs(5): Grammar and style fixes
Clean up grammar and style issues introduced by recent updates. Also,
I'm not certain inappropriate options are always ignored.
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Steve Dickson <[email protected]>
commit ab2cdb859f738a25e2567a2ec674cfa78a0a175d
Author: Chuck Lever <[email protected]>
Date: Thu Oct 28 13:13:19 2010 -0400