Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share code review guidelines #12

Open
OleksiyRudenko opened this issue Jan 28, 2019 · 5 comments
Open

Share code review guidelines #12

OleksiyRudenko opened this issue Jan 28, 2019 · 5 comments

Comments

@OleksiyRudenko
Copy link
Member

Both this repo and frontend-2019-homeworks need Code Review Guidelines (hereinafter the "CRG") while the latter are part of this repo only.

Possible options to resolve:

  • in frontend-2019-homeworks add link to frontend-2019-p2p/code-review-guidelines.md
  • move code-review-guidelines.md to kottans/frontend and add links in frontend-2019-* repos
  • (worst) make a clone of code-review-guidelines.md and post to frontend-2019-homeworks

Things to consider:

  • CRG might be useful for other courses beyond frontend (while code samples are definitely frontend specific)
  • ongoing offline course can survive without its own copy of CRG, as we expect students become CR gurus after 2-3 code review sessions
@o-msh
Copy link
Member

o-msh commented Jan 29, 2019

I can do it according to second options (move .md to kottans/frontend and add links). Also we can append some code review instructions in future. We have guidelines according to FE course except couple of common links in top of instructions. IMO while we doesn't have any different course yet. YAGNI. @OleksiyRudenko what do you think about it?

@zonzujiro
Copy link
Member

kottans/frontend is a good option, as for me.

@OleksiyRudenko
Copy link
Member Author

OleksiyRudenko commented Feb 3, 2019

Looks like migration to kottans/frontend is the option.
Let's see how things go with p2p model (will it survive, shall we be able to switch to p2p model completely) and if offline course students really need CRG when it is time to conduct peer CR within offline course.
No hurry at the time being so we still can wait and see. Meanwhile other opinions may arrive here.

@o-msh , @zonzujiro , thank you for your input, guys!

@OleksiyRudenko
Copy link
Member Author

As we have multiple courses and current course as of time of writing this is backend we may want the CRG be a part of something more global.
Luckily we now have kottans/library

@OleksiyRudenko
Copy link
Member Author

Keep #11 in mind if the CRG would migrate somewhere else.

dafen173 pushed a commit to dafen173/frontend-2019-p2p that referenced this issue Apr 27, 2020
* List a tiny JS world by kalash14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants