New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codestyle1 #1

Open

buter-brod opened this issue May 22, 2018 · 0 comments

Collaborator

buter-brod commented May 22, 2018

clinic_api/HistoryQuery.cpp

Line 27 in 017efd8

    
           jsonResponse["survey"][count % 5]["specialst"]["specialist_id"] = std::string(res->getString("expert_id_fk"));

codestyle:

jsonResponse["survey"][count % 5] можно вынести и не дублировать в каждой строке.
магическое число 5 следует объявить.
напрашивается форматирование, где одинаковые куски ("= std::string(res->getString(") окажутся друг под другом для удобства чтения.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment