Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do about pull requests on Eric's KineticJS #5

Closed
leohenning opened this issue Jan 16, 2015 · 3 comments
Closed

What to do about pull requests on Eric's KineticJS #5

leohenning opened this issue Jan 16, 2015 · 3 comments

Comments

@leohenning
Copy link

I had a pull request on Eric's Kinetic GIT page. What should I do? Is there an easy way to move it over?
@ghost
Copy link

ghost commented Jan 18, 2015

I am far from an expert on git, but here is a thought on what I might do (or at least try).

fork this repository and change the remote in you local to point to that repository, then merge. This should allow you to make the same pull request to this repo.

There are commands to do this, but typically I just edit .git/config easier and less room for error, since this repository is just another fork, most of the commits will sync over.

@lavrton
Copy link
Member

lavrton commented Jan 19, 2015

@leohenning are you talking about this request: ericdrowell/KineticJS#1043?

I will merge soon.

@lavrton
Copy link
Member

lavrton commented Jan 21, 2015

Merged. I change api from offsets to frameOffsets.

@lavrton lavrton closed this as completed Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lavrton @leohenning