Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKCE support to redmine_oauth_controller #69

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

juvex-fi
Copy link

@juvex-fi juvex-fi commented Jan 2, 2025

Add PKCE Support to Redmine OAuth Plugin

This pull request adds PKCE (Proof Key for Code Exchange) support to the redmine_oauth_controller.

Changes:

  • Generate code_verifier and code_challenge for the OAuth flow.
  • Include code_challenge and code_challenge_method in the authorization request.
  • Use code_verifier during the token exchange to improve security.

Benefits:

  • Enhances security by preventing authorization code interception.
  • Complies with OAuth 2.0 PKCE standards.

Tested with the following providers:

  • Custom

@picman picman changed the base branch from main to devel January 2, 2025 09:37
@picman picman added the enhancement New feature or request label Jan 2, 2025
@picman picman self-requested a review January 2, 2025 09:38
@picman picman added this to the 3.0.2 milestone Jan 2, 2025
Copy link
Collaborator

@picman picman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Rubocop errors.

@juvex-fi juvex-fi requested a review from picman January 2, 2025 09:54
@picman picman merged commit 9041ead into kontron:devel Jan 2, 2025
1 check passed
@picman
Copy link
Collaborator

picman commented Jan 2, 2025

Thank you!

@juvex-fi juvex-fi deleted the feature/add-pkce-support branch January 2, 2025 10:00
@picman
Copy link
Collaborator

picman commented Jan 2, 2025

I can confirm that it works with Azure AD too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants