-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme based on cover not working with black-white cover #545
Comments
Yeah. What color do we expect with black/white cover? |
I don't think a black/white theme is something we would like to see? |
I still prefer black/white color as they should be over the app theme tbh. In some entries for example: 346485 (nh id), we know that is color like orange/brown tone but app using dynamic color (blue in my case) because (I think) it detect the white text. That's really weird with orange and blue combination. |
Could you provide some screenshot? |
Contents warning!! NSFWthis example showing ugly color compare with cover imagethese examples showing entries that seem like using white theme already (maybe a little color but my eyes didn't see different from white color)Since these one already contains white color, I don't think there is much problem if using black/white in non-color cover entries in my opinion |
overall, should be better than my dynamic color that not make sense to me. |
Steps to reproduce
Expected behavior
should using black/white color as theme based on cover
Actual behavior
app will using user theme instead (in my case, app using light blue same as my dynamic color theme)
Crash logs
No response
Komikku version
1.12.1-9577
Android version
Android 14
Device
Xiaomi 14 (houji)
Other details
I'm not sure if this bugs or not, I still suggest this fix after all.
Acknowledgements
The text was updated successfully, but these errors were encountered: