Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared title and source entries share one download folder #538

Open
7 tasks done
JoeloJoestar opened this issue Nov 16, 2024 · 0 comments
Open
7 tasks done

Shared title and source entries share one download folder #538

JoeloJoestar opened this issue Nov 16, 2024 · 0 comments

Comments

@JoeloJoestar
Copy link

Steps to reproduce

  1. Add more entries from the same source and having the same origin title
  2. Download a chapter from one of them

Expected behavior

Each entry has its own download folder and do not collide to each other.
A downloaded chapter of an entry won't be opened inside another entry with the same name.

Actual behavior

Downloading a chapter in one of the entries means downloading it for all of the entries sharing the same title and source.
So by opening any of those entries we can read only the chapters from the entry we downloaded first.

The fetched pages when live reading are correctly separated from each entry in the private app storage, but downloaded chapters are placed in the same storage folder.

This might happen more frequently from those sources having an option to shorten the title (Imhentai, Nhentai) activated, which removes annoying brackets and other info from the title before recording it in the database (no custom title), but regardless, this should not happen.

Crash logs

No response

Komikku version

r9576

Android version

Android 12/13

Device

OnePlus 5T, Lenovo Tab M3+

Other details

#304 is a potential solution, but I also suggest to investigate the possibility to use comic.info (?) or creating folders titled with a suffix representing the unique ID of the entry of that source.

📼 A PoC video is published in the NSFW channel on Discord.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 1.12.1.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant