Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialisation of the event set #220

Open
maartenarnst opened this issue Nov 19, 2023 · 0 comments
Open

initialisation of the event set #220

maartenarnst opened this issue Nov 19, 2023 · 0 comments

Comments

@maartenarnst
Copy link
Contributor

The tools currently initialise the event set by using

Kokkos::Tools::Experimental::EventSet my_event_set;
  memset(&my_event_set, 0,
         sizeof(my_event_set));  // zero any pointers not set here

As @dalg24 had pointed out in

it may be better to initialise the event set by another form of initialisation.

It seems the event set is an aggregate. If we want to initialise it like

EventSet my_event_set{};

two questions are:

  • should we assign default values (e.g. NULL or nullptr) to the function pointers in the struct?
  • should something be done for the char*?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant