-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bypass cf use puppeteer #42
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but several comments.
Also the await this.ready
is weird everywhere, you could extract the authorization part into a new function and then call it only when session token expired.
### markdown | ||
<!-- ### markdown | ||
|
||
- 类型:`boolean` | ||
- 默认值:`false` | ||
|
||
是否以 Markdown 格式回复。 | ||
是否以 Markdown 格式回复。 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it? Markdown parse is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will work on it by using markdown
plugin but at next pr.
So can this PR be merged soon?I'd like to use ChatGPT on my koishi. |
For many reason,this plugin can actually not work properly. |
This PR has many problems which block it from being merged. The good news is you can try other plugins from the market. |
fix #39. fix #40. fix #38.