Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass cf use puppeteer #42

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: bypass cf use puppeteer #42

wants to merge 6 commits into from

Conversation

Seidko
Copy link
Member

@Seidko Seidko commented Mar 24, 2023

fix #39. fix #40. fix #38.

@Seidko Seidko requested review from MaikoTan and shigma March 24, 2023 14:18
docs/index.md Outdated Show resolved Hide resolved
Copy link
Member

@MaikoTan MaikoTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but several comments.

Also the await this.ready is weird everywhere, you could extract the authorization part into a new function and then call it only when session token expired.

Comment on lines -38 to +10
### markdown
<!-- ### markdown

- 类型:`boolean`
- 默认值:`false`

是否以 Markdown 格式回复。
是否以 Markdown 格式回复。 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it? Markdown parse is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on it by using markdown plugin but at next pr.

docs/index.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/api.ts Outdated Show resolved Hide resolved
src/api.ts Outdated Show resolved Hide resolved
src/api.ts Outdated Show resolved Hide resolved
src/api.ts Outdated Show resolved Hide resolved
src/api.ts Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@ConstasJ
Copy link

So can this PR be merged soon?I'd like to use ChatGPT on my koishi.

@ConstasJ
Copy link

So can this PR be merged soon?I'd like to use ChatGPT on my koishi.

For many reason,this plugin can actually not work properly.

@shigma
Copy link
Member

shigma commented Apr 22, 2023

So can this PR be merged soon?I'd like to use ChatGPT on my koishi.

This PR has many problems which block it from being merged. The good news is you can try other plugins from the market.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants