Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subject is deprecated #18

Closed
boan-jfm opened this issue May 2, 2023 · 1 comment
Closed

Subject is deprecated #18

boan-jfm opened this issue May 2, 2023 · 1 comment

Comments

@boan-jfm
Copy link

boan-jfm commented May 2, 2023 •
edited
Loading

From PHP version 8.1 it is deprecated to give null as subject parameter to preg_match: https://www.php.net/manual/en/function.preg-match.php

Image
image
https://tehplayground.com/66bDQ6thbWYTef4D

Code - parameter to methods are nullable

mail/src/Message.php

Lines 325 to 327 in e391f2b

public function setText(?string $text): void
{
if (preg_match('//u', $text) !== 1) {

mail/src/Message.php

Lines 347 to 349 in e391f2b

public function setHTML(?string $html): void
{
if (preg_match('//u', $html) !== 1) {

@thomasnordahl-dk
Copy link
Member

Duplicate of #15

@thomasnordahl-dk thomasnordahl-dk marked this as a duplicate of #15 May 2, 2023
@thomasnordahl-dk thomasnordahl-dk closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2023
@thomasnordahl-dk thomasnordahl-dk closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasnordahl-dk @boan-jfm