Upgrade to php 8.4 (#3)

* Added test script to composer.json #KDS-559

* Added PHP 8.4 to CI #KDS-559

* Fixed deprecation in JPEGService

Author: vortrixs

.github/workflows/test.yml

@@ -1,6 +1,6 @@
 name: Codeception Tests
 
-on: [push]
+on: [ push ]
 
 jobs:
   build:
@@ -11,18 +11,18 @@ jobs:
     strategy:
       matrix:
         operating-system: [ ubuntu-latest, ubuntu-22.04 ]
-        php: [ '8.0', '8.1']
+        php: [ '8.0', '8.1', '8.4' ]
 
     steps:
       - uses: actions/checkout@master
 
       - name: Setup PHP
-        uses: nanasess/setup-php@master
+        uses: shivammathur/setup-php@master
         with:
           php-version: ${{ matrix.php }}
 
       - name: Install dependencies
         run: composer install
 
       - name: Run tests
-        run: php vendor/bin/codecept run
+        run: composer run test

composer.json

@@ -19,5 +19,8 @@
     "require-dev": {
         "codeception/codeception": "^5.0.1",
         "codeception/module-asserts": "^3.0.0"
+    },
+    "scripts": {
+        "test": "codecept run"
     }
 }

src/JPEGService.php

@@ -13,38 +13,27 @@
  */
 class JPEGService
 {
-    /**
-     * @var string
-     */
-    private $bin_path;
-
-    /**
-     * @var string
-     */
-    private $args;
-
     /**
      * @param string|null $bin_path optional path to `jpeg-recompress` binary (defaults to a built-in binary)
      * @param string      $args     command-line arguments for `jpeg-recompress`, with {INPUT} and {OUTPUT} placeholders
      */
-    public function __construct(string $bin_path = null, string $args = "--min 50 {INPUT} {OUTPUT}")
-    {
+    public function __construct(
+        private ?string $bin_path = null,
+        private string $args = "--min 50 {INPUT} {OUTPUT}"
+    ) {
         if ($bin_path === null) {
             $bin_dir = dirname(__DIR__) . DIRECTORY_SEPARATOR . "bin" . DIRECTORY_SEPARATOR;
 
             if (strncasecmp(PHP_OS, "LINUX", 5) === 0) {
-                $bin_path = $bin_dir . "linux" . DIRECTORY_SEPARATOR . "jpeg-recompress";
+                $this->bin_path = $bin_dir . "linux" . DIRECTORY_SEPARATOR . "jpeg-recompress";
             } elseif (strncasecmp(PHP_OS, "DARWIN", 6) === 0) {
-                $bin_path = $bin_dir . "mac" . DIRECTORY_SEPARATOR . "jpeg-recompress";
+                $this->bin_path = $bin_dir . "mac" . DIRECTORY_SEPARATOR . "jpeg-recompress";
             } elseif (strncasecmp(PHP_OS, "WIN", 3) === 0) {
-                $bin_path = $bin_dir . "win" . DIRECTORY_SEPARATOR . "jpeg-recompress.exe";
+                $this->bin_path = $bin_dir . "win" . DIRECTORY_SEPARATOR . "jpeg-recompress.exe";
             } else {
                 throw new RuntimeException("unsupported OS: " . PHP_OS);
             }
         }
-
-        $this->bin_path = $bin_path;
-        $this->args = $args;
     }
 
     /**
@@ -55,7 +44,7 @@ public function __construct(string $bin_path = null, string $args = "--min 50 {I
      *
      * @throws ProcessFailedException on failure to execute the command-line tool
      */
-    public function compress(string $input, string $output)
+    public function compress(string $input, string $output): void
     {
         $command = strtr(
             "{$this->bin_path} {$this->args}",