Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Should we use the original configuration arguments when building ngx_brotli? #1

Open
luxlogica opened this issue Oct 4, 2020 · 1 comment

Comments

@luxlogica
Copy link

luxlogica commented Oct 4, 2020

It seems the Brotli installation playbook builds the module like this:

./configure --with-compat --add-dynamic-module=../ngx_brotli

However, the build instructions in the google/ngx_brotli repository warn us that we should use exactly the same configuration options that Nginx was built with, otherwise we will get an error:

"You will need to use exactly the same ./configure arguments as your Nginx configuration and append --with-compat --add-dynamic-module=/path/to/ngx_brotli to the end, otherwise you will get a "module is not binary compatible" error on startup. You can run nginx -V to get the configuration arguments for your Nginx installation."

Should the playbook be getting the configuration arguments with nginx -V, and then using them in the ./configure command?

@koddr
Copy link
Owner

koddr commented Mar 9, 2021

@luxlogica hi!

Thanks for the question. As far as I know, this warning does not take into account the fact that when you start installing the brotli module, it already uses exactly the same configuration as the installed nginx.

In any case, this playbook has been tested many times already on different VPS and never had a problem with it.

If you have any other comments, please post them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants