Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI testing on a real Kobuki #19

Open
slivingston opened this issue Oct 30, 2020 · 2 comments
Open

CI testing on a real Kobuki #19

slivingston opened this issue Oct 30, 2020 · 2 comments

Comments

@slivingston
Copy link

I propose to add integration with a CI testing service that runs on a real Kobuki robot. Can I get your feedback:

  1. is there already something like this, or does everyone just manually try code on their own Kobuki?
  2. for tests, should I just collect output from kobuki_testsuite ?
  3. assuming you want this, is sending a pull request the best way to offer it?

I made a basic system for time-sharing robots, and now I am building services on top of it. You can try an interactive sandbox: https://rerobots.net/sandbox/multi_kobuki?e=rospy (also there is a screenshot on Twitter). The robot is physically in SF Bay Area, so expect some latency. However, automated tests (proposed in this issue) would run entirely locally, so latency would not be significant for CI testing.

This work could make reviewing PRs like #9 easier.

@stonier
Copy link
Contributor

stonier commented Nov 16, 2020

I need to free up some time to make a concerted push on this again - next step really is to prop them up with test suites and drop them on the OSRC build farm (with github hooks). We really can't advance the source code beyond this first pass with confidence unless we have that automated testing. If you can make a PR to kobuki_testsuite I'd be happy to review it (actually any other testing as well).

@slivingston
Copy link
Author

@stonier thanks. I will begin work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants